Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933524AbdGLIIL (ORCPT ); Wed, 12 Jul 2017 04:08:11 -0400 Received: from mail-qt0-f172.google.com ([209.85.216.172]:35931 "EHLO mail-qt0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933479AbdGLIIE (ORCPT ); Wed, 12 Jul 2017 04:08:04 -0400 MIME-Version: 1.0 In-Reply-To: <20170630183927.GA13036@ubuntulaptop> References: <1498798361-9965-1-git-send-email-mail@mark-rogers.org> <20170630183927.GA13036@ubuntulaptop> From: Frans Klaver Date: Wed, 12 Jul 2017 10:08:03 +0200 Message-ID: Subject: Re: [PATCH] staging: ks7010: fix styling WARNINGs To: Mark Rogers Cc: Greg KH , "Tobin C. Harding" , sayli karnik , driverdevel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 852 Lines: 23 On Fri, Jun 30, 2017 at 8:39 PM, Mark Rogers wrote: > Thank you for your feedback. I guess when making this patch I had the > preferred coding style in mind, but didn't ask myself if making the code > conform to it would truly improve readability. > > I agree with all of your comments. Do you think the best course of > action is to create a new patch with this change alone and forget the > rest? It's up to you. You could send a couple of patches fixing these things, or just do one patch fixing one thing. > > - DPRINTK(1, "ks7010_sdio_remove()\n"); > + DPRINTK(1, "%s()\n", __func__); > > Sorry about the newbie questions and bad patch, I will do better with > the next one. Thanks again for your time and feedback, I really > appreciate it. It's pretty much what staging is for. Don't worry about it. Frans