Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754758AbdGLI6M (ORCPT ); Wed, 12 Jul 2017 04:58:12 -0400 Received: from mail-wr0-f175.google.com ([209.85.128.175]:35753 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbdGLI6I (ORCPT ); Wed, 12 Jul 2017 04:58:08 -0400 Date: Wed, 12 Jul 2017 09:58:04 +0100 From: Lee Jones To: Andrea Adami Cc: linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Wolfram Sang , Daniel Mack , Haojian Zhuang , Dmitry Eremin-Solenikov , Robert Jarzmik , Linus Walleij , Russell King , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/9] mfd: tmio.h: support partition parser types Message-ID: <20170712085804.ya5b3trqbipuel3f@dell> References: <1498681836-3765-1-git-send-email-andrea.adami@gmail.com> <1498681836-3765-4-git-send-email-andrea.adami@gmail.com> <20170703112621.rd3ija3efqlq57rg@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2306 Lines: 77 On Wed, 12 Jul 2017, Andrea Adami wrote: > On Mon, Jul 3, 2017 at 2:03 PM, Andrea Adami wrote: > > On Mon, Jul 3, 2017 at 1:26 PM, Lee Jones wrote: > >> Please use the $SUBJECT line expected by the subsystem. > >> > >> `git log --oneline -- $SUBSYSTEM` can help with this. > >> > >> You also need a commit log. > >> > > > > Lee, > > > > thanks for spotting it. > > I'll fix the subject and add a little text in these patches touching headers. > > > > I am awaiting for a new review of the big piece of the patch, the > > ftl/parser, then I'll send a fixed v5. > > > > > > Lee, > > I have looked at the history of mfd/tmio.h but couldn't find > unambiguous examples. > Do you prefer > > Subject: mfd: tmio: tmio_nand: add partition parsers platform data > or > Subject: mfd: tmio: tmio-nand: add partition parsers platform data > or > Subject: mfd: tmio: tmio/nand: add partition parsers platform data Better to look at the subsystem as a whole. `git log --oneline -- drivers/mfd` You will see something like: mfd: device-driver: Short subject starting with an uppercase char > >>> Signed-off-by: Andrea Adami > >>> --- > >>> include/linux/mfd/tmio.h | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > >>> index a1520d8..23bb069 100644 > >>> --- a/include/linux/mfd/tmio.h > >>> +++ b/include/linux/mfd/tmio.h > >>> @@ -139,6 +139,7 @@ struct tmio_nand_data { > >>> struct nand_bbt_descr *badblock_pattern; > >>> struct mtd_partition *partition; > >>> unsigned int num_partitions; > >>> + const char *const *types; /* names of parsers to use if any */ > >> > >> I'm okay with this if it's suits the MTD folk. > >> > > > > Other than kerneldoc comments there are maybe other little > > discordances to settle: see above is *partition, num_partitions. > > In the other header it is *partitions, nr_partitions ...I'll see if > > oneday I can janiitor this. > > > > Regards > > Andrea > > > >>> }; > >>> > >>> #define FBIO_TMIO_ACC_WRITE 0x7C639300 > >> -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog