Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755645AbdGLJQj (ORCPT ); Wed, 12 Jul 2017 05:16:39 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34863 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbdGLJQg (ORCPT ); Wed, 12 Jul 2017 05:16:36 -0400 Subject: Re: [PATCH 2/4] arm64: dts: rockchip: add ARM Mali GPU node for RK3399 SoCs To: Heiko Stuebner Cc: Caesar Wang , Douglas Anderson , devicetree@vger.kernel.org, Brian Norris , Catalin Marinas , Shawn Lin , Elaine Zhang , Will Deacon , Kever Yang , Mark Rutland , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Roger Chen , William wu , rocky.hao@rock-chips.com, linux-arm-kernel@lists.infradead.org References: <1499840971-20392-1-git-send-email-wxt@rock-chips.com> <1499840971-20392-3-git-send-email-wxt@rock-chips.com> <4066931.s766IOqHgB@phil> From: Caesar Wang Message-ID: <3c3a2e24-7cb1-dc31-6532-1d6182bdf3ee@gmail.com> Date: Wed, 12 Jul 2017 17:16:29 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <4066931.s766IOqHgB@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2344 Lines: 73 在 2017年07月12日 15:19, Heiko Stuebner 写道: > Hi Caesar, > > Am Mittwoch, 12. Juli 2017, 14:29:28 CEST schrieb Caesar Wang: >> Add Mali GPU device tree node for the RK3399 SoCs, with devfreq >> opp table. >> >> RK3399 and RK3399-OP1 SoCs have a different recommendation table with >> gpu opp. As the ARM's mali driver found on >> https://developer.arm.com/products/software/mali-drivers/midgard-kernel. >> >> Signed-off-by: Caesar Wang >> --- >> >> arch/arm64/boot/dts/rockchip/rk3399-op1-opp.dtsi | 33 ++++++++++++++++++++++++ >> arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi | 33 ++++++++++++++++++++++++ >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 16 ++++++++++++ >> 3 files changed, 82 insertions(+) > [...] > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> index 1cbd7a2..8c6438b 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -1443,6 +1443,22 @@ >> status = "disabled"; >> }; >> >> + gpu: gpu@ff9a0000 { >> + compatible = "arm,rk3399-mali", >> + "arm,malit860", >> + "arm,malit86x", >> + "arm,malit8xx"; > no wildcards and correct compatibles please. > The binding specifies arm,mali-t860 for your chip and the soc > specific compatible needs a rockchip vendor, so you need > > compatible = "rockchip,rk3399-mali", "arm,mali-t860"; > Okay, sound resonable. >> + reg = <0x0 0xff9a0000 0x0 0x10000>; >> + interrupts = , >> + , >> + ; >> + interrupt-names = "GPU", "JOB", "MMU"; > interrupt names are job, mmu, gpu in lower case. The out-of-tree driver > will need to conform to that. Okay, we need update the ARM's mali driver to follow up. >> + clocks = <&cru ACLK_GPU>; >> + clock-names = "clk_mali"; > no clock-names property, as midgard malis only have one clock input Sorry, I seem to be reference for the MAILI's document, not the Linux document. Update these for patches v2. Thanks your comments. -Caesar > > Heiko > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip