Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755980AbdGLJaL (ORCPT ); Wed, 12 Jul 2017 05:30:11 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:34992 "EHLO mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdGLJaJ (ORCPT ); Wed, 12 Jul 2017 05:30:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <1498214246-1244-1-git-send-email-marcin.nowakowski@imgtec.com> <14a3d7aa-8038-470a-4166-7da6985241a2@kernel.org> From: Naresh Kamboju Date: Wed, 12 Jul 2017 15:00:06 +0530 Message-ID: Subject: Re: [PATCH 0/3] kselftest build errors To: Fathi Boudra Cc: Shuah Khan , Marcin Nowakowski , SeongJae Park , linux-kselftest@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2030 Lines: 56 Hi Fathi and Shuah, On 29 June 2017 at 14:07, Fathi Boudra wrote: > On 28 June 2017 at 17:21, Shuah Khan wrote: >> On 06/28/2017 02:30 AM, Fathi Boudra wrote: >>> On 23 June 2017 at 22:44, Shuah Khan wrote: >>>> On 06/23/2017 04:37 AM, Marcin Nowakowski wrote: >>>>> This patch series fixes build errors observed when building net, memfd, gpio and intel_pstate tests >>>>> >>>>> Marcin Nowakowski (3): >>>>> selftests/{net,memfd}: fix undefined references to external libraries >>>>> selftests/gpio: fix build error >>>>> selftests/intel_pstate: fix undefined reference when building >>>>> >>>>> tools/testing/selftests/gpio/Makefile | 2 +- >>>>> tools/testing/selftests/intel_pstate/Makefile | 2 +- >>>>> tools/testing/selftests/memfd/Makefile | 4 ++-- >>>>> tools/testing/selftests/net/Makefile | 2 +- >>>>> 4 files changed, 5 insertions(+), 5 deletions(-) >>>>> >>>> >>>> Hi Marcin, >>>> >>>> SeongJae Park sent me fixes for the memfd/net/intel_pstate problems >>>> last week. I pulled those in already. >>>> >>>> The gpio fix is something I need to look at closely to see if this is >>>> the way to go. I will get back to you on that. >>> >>> Any updates on the gpio fix? I've tested it and it works for me. >>> >> >> I haven't decided yet. > > another alternative is to use realpath: > -GPIODIR := ../../../gpio > +GPIODIR := $(realpath ../../../gpio) > > btw, this commit: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=51c6bd7cbe0366b642d8ac90d98739c39ab091a9 > should be reverted once the build error is addressed because they > shouldn't have been there in the first place due to lack of trailing > slash in the path. The current status on linux-next is, gpio-mockup-chardev.c building binary failed and shell script not able to locate test binary, gpio-mockup-chardev: No such file or directory Bug link, https://bugs.linaro.org/show_bug.cgi?id=3122 - Naresh > >> thanks, >> -- Shuah