Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756747AbdGLLqM (ORCPT ); Wed, 12 Jul 2017 07:46:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52248 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756677AbdGLLqL (ORCPT ); Wed, 12 Jul 2017 07:46:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 839F161246 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tirupath@codeaurora.org Subject: Re: [PATCH 1/1] regulator: core: fix a possible race in disable_work handling To: Mark Brown Cc: lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1499851787-31016-1-git-send-email-tirupath@codeaurora.org> <20170712100250.kjbedwzdfuiq7ycs@sirena.org.uk> From: Tirupathi Reddy T Message-ID: <5b4da9ca-b641-7723-5d96-af6e5f481454@codeaurora.org> Date: Wed, 12 Jul 2017 17:16:05 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170712100250.kjbedwzdfuiq7ycs@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 588 Lines: 14 On 7/12/2017 3:32 PM, Mark Brown wrote: > On Wed, Jul 12, 2017 at 02:59:47PM +0530, Tirupathi Reddy wrote: > >> regulator_disable_deferred: regulator_disable_work: >> mutex_lock(&rdev->mutex); ..... >> rdev->deferred_disables++; mutex_lock(&rdev->mutex); >> mutex_unlock(&rdev->mutex); ..... >> queue_delayed_work(...) count =rdev->deferred_disables; >> ..... rdev->deferred_disables = 0; > This shows two things simultaneously holding rdev->mutex... Fixed this in the new patch version(V2). https://patchwork.kernel.org/patch/9836529/