Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756721AbdGLMET (ORCPT ); Wed, 12 Jul 2017 08:04:19 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:37338 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756460AbdGLMER (ORCPT ); Wed, 12 Jul 2017 08:04:17 -0400 MIME-Version: 1.0 In-Reply-To: References: <359d62c1f2f7ef61c6160df9b60c1af4bfcea89a.1496664241.git.baolin.wang@spreadtrum.com> <20170612060718.GA8566@spreadtrum.com> <20170613031547.GA29679@spreadtrum.com> From: Linus Walleij Date: Wed, 12 Jul 2017 14:04:15 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] DT: pinctrl: Add binding documentation for Spreadtrum pin controller To: Baolin Wang Cc: Mark Rutland , Rob Herring , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 24 On Tue, Jun 27, 2017 at 9:59 AM, Baolin Wang wrote: > On 26 June 2017 at 06:19, Linus Walleij wrote: >> I meant, as part of setting the "default" state or even the "init" >> state, we would inspect the "sleep" state, use those settings, and >> program them into the registers at this early point. > > I understood your points. But we can not program all into the > registers at one early point, sometimes these sleep-related configs > need depend on some conditions in users' drivers, like on condition 1: > driver need to set one pin as input-enable when specified system goes > into deep sleep, on condition 2: driver need set this pin as > output-enable when specified system goes into deep sleep. So I still > think it is better if we introduce some standard sleep related > configs. So you mean you need special runtime states to set up sleep states? Do you have an example of how this would look in the device tree? I am sorry but I have a hard time following the use case :( Yours, Linus Walleij