Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756550AbdGLMPt (ORCPT ); Wed, 12 Jul 2017 08:15:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34750 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755886AbdGLMPr (ORCPT ); Wed, 12 Jul 2017 08:15:47 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8BAF7612BB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V4] PCI: Add Extended Tags quirk for Broadcom HT2100 Root Port To: Ethan Zhao , Wim ten Have Cc: linux-pci , timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , LKML References: <1499832255-9845-1-git-send-email-okaya@codeaurora.org> <20170712105550.6007fa06.wim.ten.have@oracle.com> From: Sinan Kaya Message-ID: Date: Wed, 12 Jul 2017 08:15:43 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 23 On 7/12/2017 5:44 AM, Ethan Zhao wrote: > The dmesg yelled "...Tag handling is broken" , but didn't say how it > was handled, that is weird and confusing, just because there is no > device under that bridge ? > > How about move the messages together "...is broken, disable Extended tag..." This was something requested by Bjorn to inform that user has a broken HW when a quirk is matched. The new code will disable extended tags only if it was enabled on endpoint via power on reset value or via some broken BIOS. It looks like we are not seeing any disabling message. This implies that both the card and BIOS is good. That's why, you are no longer seeing a disabling message on this system and code is just not enabling extended tags. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.