Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752481AbdGLNSy (ORCPT ); Wed, 12 Jul 2017 09:18:54 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:7261 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbdGLNSx (ORCPT ); Wed, 12 Jul 2017 09:18:53 -0400 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 12 Jul 2017 06:18:52 -0700 Subject: Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations To: Gerd Hoffmann , Alex Williamson CC: Xiaoguang Chen , , , , , , , , References: <1497513611-2814-1-git-send-email-xiaoguang.chen@intel.com> <1497513611-2814-6-git-send-email-xiaoguang.chen@intel.com> <1497542438.29252.1.camel@redhat.com> <20170615143833.7526351b@w520.home> <24c4880b-24f5-ea07-834c-c77d3e895c78@nvidia.com> <20170616103959.3b6f1681@t450s.home> <1497854053.4207.2.camel@redhat.com> <20170619085409.26f5c14c@w520.home> <1497947703.16795.4.camel@redhat.com> <791b0316-1c83-622c-9cef-d54dae1209f9@nvidia.com> <1498029758.5802.1.camel@redhat.com> X-Nvconfidentiality: public From: Kirti Wankhede Message-ID: <42b821d9-9467-1679-3351-4a234243f520@nvidia.com> Date: Wed, 12 Jul 2017 18:48:47 +0530 MIME-Version: 1.0 In-Reply-To: <1498029758.5802.1.camel@redhat.com> X-Originating-IP: [10.24.205.12] X-ClientProxiedBy: BGMAIL104.nvidia.com (10.25.59.13) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1452 Lines: 52 Hey Gerd, Sorry, I missed this mail earlier. On 6/21/2017 12:52 PM, Gerd Hoffmann wrote: > Hi, > >> We don't support cursor for console vnc. Ideally console vnc should >> be >> used by admin for configuration or during maintenance, which refresh >> primary surface at low refresh rate, 10 fps. > > But you surely want a mouse pointer for the admin? > You render it directly to the primary surface then I guess? > If cursor surface is not provided, a dot for cursor is seen on the primary surface, which is pretty much usable. >> Right we need to know this at device initialization time for both >> cases >> to initialize VGACommonState structure for that device > > Why do you need a VGACommonState? > We need to create a GRAPHIC_CONSOLE for vGPU device and specify GraphicHwOps so that from its .gfx_update callback, surface can be queried and updated. >> and also need >> NONE to decide whether to init console vnc or not. We have a >> mechanism >> to disable console vnc path and we recommend to disable it for better >> performance. > > Hmm, maybe we should have a ioctl to configure the refresh rate, or a > ioctl to allow qemu ask for a refresh when needed? > What is default refresh rate of QEMU if vnc is connected? Thanks, Kirti > qemu can throttle the display update rate, which for example happens in > case no vnc client is connected. qemu updates the display only once > every few seconds then. > > cheers, > Gerd >