Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752689AbdGLNmP (ORCPT ); Wed, 12 Jul 2017 09:42:15 -0400 Received: from mail-by2nam01on0082.outbound.protection.outlook.com ([104.47.34.82]:62304 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752309AbdGLNmM (ORCPT ); Wed, 12 Jul 2017 09:42:12 -0400 From: "Mintz, Yuval" To: Colin King , "netdev@vger.kernel.org" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Elior, Ariel" Subject: RE: [PATCH] net: broadcom: bnx2x: make a couple of const arrays static Thread-Topic: [PATCH] net: broadcom: bnx2x: make a couple of const arrays static Thread-Index: AQHS+jPIPoQmV6cQJkmvKuCIO6XrRaJQM/rg Date: Wed, 12 Jul 2017 13:42:03 +0000 Message-ID: References: <20170711105223.14024-1-colin.king@canonical.com> In-Reply-To: <20170711105223.14024-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [31.168.140.228] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM2PR0701MB1342;7:H34SL5Sb6JVFKihiWdYc1LUQHtVVqfR4b8uIa6FefoA0+X4Wua0dUpPl7e/k5IqwN2BISvZ1FolDIrLQse0IYnqMjnTv07r/EepEI5HVP4W/raPH3Gve7dvFwLia4Sz+cS/9zx62Zkg3quUVvcBcx1N1vIj1D0+MhR+1mX4STpKQAERTsIozsM2T5YVT1aXaCxwL8ewLr5Ty+5ij3ABeXI7RVcFCISqiFeCp+LtLZT+eFrg03ai3cz43fs/6JtMMPTl3H4ZfFqbJaj2ZWN/5Ne/he7CQySCen5Y04Ov4Qll8dP+/uikO8Ree5UKQ2pYe97RQ3GC60luNF7xHhRbsY//g36y1IVW0MUzf3UXvGOGPBrNYCyz4J82JzYV33er8x1fnK26GUvDHHZgfawMDJgZbt0lUKPZ8AsYrjdC+AmwIlfATVNFu9w/GDtbwqVah2QSc7vb7zRgImgEjRGhDMLosmz7MZ//MH5BHCxP1ctkOzsLolBK/cG4SBC+A6d0Yw3YDqtcbxTI4ir4+VH1da2/NsFTkKsOhIFtVYYvCAgdq98mtGKIKPIIds2PAJy8fVNveA5pZ5f0Wffp7rAFCiEYHuWIcyg/LMid4djk8oDoh3pkYVd4xPbsXYrFzeC+FcpHQiSNwQtkU4rJnKOCBbvDHMUTEYIhKflKQpmfiauCWHSSDNBCLICHJHqKYz2S2OmdcqRMsPalO8IfFcN6b6kMuoLjRPZimwm67gBxXmM8xsbqEF8b+i4CldTEgv1fAx2uq6prqhR5jzpzrc2ljJCpeFTY5r4jtm/RRIrdZ3U8= x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39450400003)(39400400002)(39410400002)(2906002)(9686003)(305945005)(81166006)(7736002)(25786009)(4326008)(189998001)(8936002)(2501003)(2950100002)(6246003)(3280700002)(38730400002)(76176999)(53936002)(107886003)(8676002)(66066001)(74316002)(86362001)(3660700001)(50986999)(229853002)(77096006)(54356999)(7696004)(5660300001)(14454004)(33656002)(478600001)(54906002)(55016002)(99286003)(6506006)(6116002)(6436002)(2900100001)(3846002)(72206003)(102836003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR0701MB1342;H:BLUPR0701MB2004.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-office365-filtering-correlation-id: f513c328-4a7a-4234-7b9b-08d4c92bc78d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM2PR0701MB1342; x-ms-traffictypediagnostic: DM2PR0701MB1342: x-exchange-antispam-report-test: UriScan:(236129657087228)(198206253151910); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(2017060910075)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR0701MB1342;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR0701MB1342; x-forefront-prvs: 036614DD9C spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2017 13:42:03.3859 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0701MB1342 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6CDgXbV031665 Content-Length: 493 Lines: 15 > Don't populate various tables on the stack but make them static const. > Makes the object code smaller by nearly 200 bytes: > > Before: > text data bss dec hex filename > 113468 11200 0 124668 1e6fc bnx2x_ethtool.o > > After: > text data bss dec hex filename > 113129 11344 0 124473 1e639 bnx2x_ethtool.o > > Signed-off-by: Colin Ian King Thanks Colin. Acked-by: Yuval Mintz