Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbdGLOOy (ORCPT ); Wed, 12 Jul 2017 10:14:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:37402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdGLOOx (ORCPT ); Wed, 12 Jul 2017 10:14:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 610B322B4C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 12 Jul 2017 10:14:49 -0400 From: Steven Rostedt To: Alex Shi Cc: peterz@infradead.org, mingo@redhat.com, corbet@lwn.net, "open list:LOCKING PRIMITIVES" , "open list:DOCUMENTATION" , Sebastian Siewior , Mathieu Poirier , Juri Lelli , Thomas Gleixner Subject: Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio Message-ID: <20170712101449.26b47984@gandalf.local.home> In-Reply-To: References: <1499395922-542-1-git-send-email-alex.shi@linaro.org> <1499395922-542-3-git-send-email-alex.shi@linaro.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1828 Lines: 56 On Tue, 11 Jul 2017 22:39:24 +0800 Alex Shi wrote: > Any comments for this little change? It's passed on 0day testing. I think the problem was that this was a third patch after two documentation patches. Where, people put documentation review at the bottom of their priority list. This should have been sent as separate patch on its own. > > Thanks > Alex > > On 07/07/2017 10:52 AM, Alex Shi wrote: > > We don't need to adjust prio before new pi_waiter adding. The prio > > only need update after pi_waiter change or task priority change. > > > > Signed-off-by: Alex Shi > > Cc: Steven Rostedt > > Cc: Sebastian Siewior > > Cc: Mathieu Poirier > > Cc: Juri Lelli > > Cc: Thomas Gleixner > > To: linux-kernel@vger.kernel.org > > To: Ingo Molnar > > To: Peter Zijlstra > > --- > > kernel/locking/rtmutex.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c > > index 28cd09e..d1fe41f 100644 > > --- a/kernel/locking/rtmutex.c > > +++ b/kernel/locking/rtmutex.c > > @@ -963,7 +963,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock, > > return -EDEADLK; > > > > raw_spin_lock(&task->pi_lock); > > - rt_mutex_adjust_prio(task); Interesting, I did some git mining and this was added with the original entry of the rtmutex.c (23f78d4a0). Looking at even that version, I don't see the purpose of adjusting the task prio here. It is done before anything changes in the task. Reviewed-by: Steven Rostedt (VMware) -- Steve > > waiter->task = task; > > waiter->lock = lock; > > waiter->prio = task->prio; > >