Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbdGLOvB (ORCPT ); Wed, 12 Jul 2017 10:51:01 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:36392 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbdGLOu7 (ORCPT ); Wed, 12 Jul 2017 10:50:59 -0400 Subject: Re: [PATCH v4 1/3] cpufreq: mediatek: Add support of cpufreq to MT2701/MT7623 SoC To: Eddie Huang , sean.wang@mediatek.com Cc: viresh.kumar@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, jamesjj.liao@mediatek.com, p.zabel@pengutronix.de, shunli.wang@mediatek.com, erin.lo@mediatek.com, jdelvare@suse.de, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jean Delvare References: <1499741386.12408.11.camel@mtksdaap41> From: Matthias Brugger Message-ID: <12f23fb1-a145-bdf0-54c8-c2818ba75d9d@gmail.com> Date: Wed, 12 Jul 2017 16:50:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1499741386.12408.11.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1823 Lines: 43 Hi Eddie, On 07/11/2017 04:49 AM, Eddie Huang wrote: > Hi Sean, > > On Mon, 2017-07-10 at 22:23 +0800, sean.wang@mediatek.com wrote: >> From: Sean Wang >> >> MT2701/MT7623 is a 32-bit ARMv7 based quad-core (4 * Cortex-A7) with >> single cluster and this hardware is also compatible with the existing >> driver through enabling CPU frequency feature with operating-points-v2 >> bindings. Also, this driver actually supports all MediaTek SoCs, the >> Kconfig menu entry and file name itself should be updated with more >> generic name to drop "MT8173" >> >> Signed-off-by: Sean Wang >> Acked-by: Viresh Kumar >> Reviewed-by: Jean Delvare >> --- >> drivers/cpufreq/Kconfig.arm | 7 +++---- >> drivers/cpufreq/Makefile | 2 +- >> drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} | 2 ++ >> 3 files changed, 6 insertions(+), 5 deletions(-) >> rename drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} (99%) >> > > As Viresh mentioned, there are already many drivers use "mtk" as > filename prefix or postfix.To align with those files, I suggest use > mtk-cpufreq.c.I think there are not too many values to change all "mtk-" > to "mediatek-", but it is worth to have the same naming rule for > mediatek upstream driver. > In the last submission Jean proposed to change all file names from mtk-*.[ch] to mediatek-*.[ch] as this will cause less confusion. Viresh are you OK with that approach or do you prefer that we stay with mtk prefix? I think it makes sense to have a unique prefix and resolve the situation we now have with source files and Kconfig options. But TBH I have no strong feeling for any of the two prefixes. Regards, Matthias