Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753518AbdGLPzh (ORCPT ); Wed, 12 Jul 2017 11:55:37 -0400 Received: from mail.efficios.com ([167.114.142.141]:33615 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbdGLPzf (ORCPT ); Wed, 12 Jul 2017 11:55:35 -0400 Date: Wed, 12 Jul 2017 15:56:49 +0000 (UTC) From: Mathieu Desnoyers To: Tom Zanussi Cc: Sebastian Andrzej Siewior , Thomas Gleixner , rostedt , linux-kernel , Michael Jeanson Message-ID: <758517446.14680.1499875009807.JavaMail.zimbra@efficios.com> Subject: Dynamic tracepoints in 4.11.8-rt5 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.142.141] X-Mailer: Zimbra 8.7.9_GA_1794 (ZimbraWebClient - FF52 (Linux)/8.7.9_GA_1794) Thread-Index: 64Jur2w15wPLmI+YKfrTh3x6TJ72Ew== Thread-Topic: Dynamic tracepoints in 4.11.8-rt5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 36 Hi Tom, I notice this commit appears in linux-rt-devel 4.11.8-rt5 (and it is not in upstream Linux): 003100371 tracing: Add support for dynamic tracepoints It adds a "bool dynamic" argument to tracepoint_probe_unregister. I'm trying to figure out why this change is introduced as a new API "dynamic_tracepoint_probe_register()" and by adding a boolean to tracepoint_probe_unregister(). Allowing the user of register API to mixup between dynamic and non-dynamic boolean values for the same tracepoint instance seems fragile. Given that the "dynamic" nature of this new kind of tracepoint appears to be associated with the tracepoint instance (struct tracepoint), why can't we simply add a "bool dynamic" field to struct tracepoint, so we can deal with this internally within tracepoint.c without exposing this detail in the register API ? This would also take care of currently diverging module APIs for the GPL-exported symbol tracepoint_unregister() between Linux upstream and linux-rt. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com