Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932328AbdGLRVs (ORCPT ); Wed, 12 Jul 2017 13:21:48 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33215 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753785AbdGLRVr (ORCPT ); Wed, 12 Jul 2017 13:21:47 -0400 Date: Wed, 12 Jul 2017 19:20:17 +0200 (CEST) From: Hans Ulli Kroll X-X-Sender: elektroman@T420s To: Benjamin Gaignard cc: linaro-kernel@lists.linaro.org, Hans Ulli Kroll , Alessandro Zummo , Alexandre Belloni , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 11/22] rtc: gemini: stop using rtc deprecated functions In-Reply-To: <1499846682-14093-12-git-send-email-benjamin.gaignard@linaro.org> Message-ID: References: <1499846682-14093-1-git-send-email-benjamin.gaignard@linaro.org> <1499846682-14093-12-git-send-email-benjamin.gaignard@linaro.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 781 Lines: 34 Hi Benjamin, On Wed, 12 Jul 2017, Benjamin Gaignard wrote: > @@ -93,12 +93,12 @@ static int ftrtc010_rtc_set_time(struct device *dev, struct rtc_time *tm) > { > struct ftrtc010_rtc *rtc = dev_get_drvdata(dev); > unsigned int sec, min, hour, day; > - unsigned long offset, time; > + unsigned long long offset, time; > > if (tm->tm_year >= 2148) /* EPOCH Year + 179 */ > return -EINVAL; > > - rtc_tm_to_time(tm, &time); > + time = rtc_tm_to_time64(tm); > > sec = readl(rtc->rtc_base + FTRTC010_RTC_SECOND); > min = readl(rtc->rtc_base + FTRTC010_RTC_MINUTE); later on this will do writel(offset, rtc->rtc_base + FTRTC010_RTC_RECORD); you are writing some 64bit value in a 32bit register ... NACK here Greetings from Cologne Hans Ulli Kroll > 1.9.1 > >