Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754150AbdGLRcO (ORCPT ); Wed, 12 Jul 2017 13:32:14 -0400 Received: from mail-pg0-f54.google.com ([74.125.83.54]:36395 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753913AbdGLRcM (ORCPT ); Wed, 12 Jul 2017 13:32:12 -0400 Date: Wed, 12 Jul 2017 10:32:09 -0700 From: Brian Norris To: Caesar Wang Cc: Heiko Stuebner , linux-rockchip@lists.infradead.org, rocky.hao@rock-chips.com, Douglas Anderson , William wu , Elaine Zhang , Kever Yang , linux-kernel@vger.kernel.org, Shawn Lin , devicetree@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , Catalin Marinas , Roger Chen Subject: Re: [PATCH 4/4] arm64: dts: rockchip: update the thermal zones for RK3399 SoCs Message-ID: <20170712173208.GA92073@google.com> References: <1499840971-20392-1-git-send-email-wxt@rock-chips.com> <1499840971-20392-5-git-send-email-wxt@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499840971-20392-5-git-send-email-wxt@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 51 Hi Caesar, On Wed, Jul 12, 2017 at 02:29:30PM +0800, Caesar Wang wrote: > As RK3399 had used the Power allocator thermal governor by default, > enabled this to manage thermals by dynamically allocating and limiting > power to devices. > > Also, this patch supported the dynamic-power-coefficient/sustainable_power > and GPU's power model for needed parameters with thermal IPA. > > Signed-off-by: Caesar Wang > > --- > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 62 +++++++++++++++----------------- > 1 file changed, 29 insertions(+), 33 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 8c6438b..139f58c 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -147,7 +147,7 @@ > enable-method = "psci"; > #cooling-cells = <2>; /* min followed by max */ > clocks = <&cru ARMCLKB>; > - dynamic-power-coefficient = <100>; > + dynamic-power-coefficient = <436>; > }; > > cpu_b1: cpu@101 { > @@ -156,7 +156,7 @@ > reg = <0x0 0x101>; > enable-method = "psci"; > clocks = <&cru ARMCLKB>; > - dynamic-power-coefficient = <100>; > + dynamic-power-coefficient = <436>; There are 6 of these properties (1 for each core now; not just 1 for each cluster), and you're only changing 2 of them. BTW, are these values determined from measurement this time? And heavily tested? The previous values were suspiciously round, but they'd been heavily tested so I didn't mind :) > }; > }; > ... Brian