Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754095AbdGLTTB (ORCPT ); Wed, 12 Jul 2017 15:19:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:57780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbdGLTS6 (ORCPT ); Wed, 12 Jul 2017 15:18:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F138222BD9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=snawrocki@kernel.org Subject: Re: [PATCH v2 2/7] [media] ov9650: switch i2c device id to lower case To: Hugues Fruchet Cc: "H. Nikolaus Schaller" , Guennadi Liakhovetski , Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre Torgue , Mauro Carvalho Chehab , Hans Verkuil , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Yannick Fertre , Benjamin Gaignard , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org References: <1499073368-31905-1-git-send-email-hugues.fruchet@st.com> <1499073368-31905-3-git-send-email-hugues.fruchet@st.com> From: Sylwester Nawrocki Message-ID: <8b84296e-b3c7-f5d1-5e90-5890b1b0ed48@kernel.org> Date: Wed, 12 Jul 2017 21:18:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1499073368-31905-3-git-send-email-hugues.fruchet@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 39 On 07/03/2017 11:16 AM, Hugues Fruchet wrote: > Switch i2c device id to lower case as it is s/i2c/I2C ? > done for other omnivision cameras. s/omnivision/Omnivision This is required for properly matching driver with device on DT platforms, right? It might be worth to mention that so it is clear why we break any non-dt platform that could be already using this driver. There seem to be none in the mainline kernel tree though. > Signed-off-by: Hugues Fruchet Reviewed-by: Sylwester Nawrocki > Signed-off-by: Hugues Fruchet > --- > drivers/media/i2c/ov9650.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c > index 2de2fbb..1e4e99e 100644 > --- a/drivers/media/i2c/ov9650.c > +++ b/drivers/media/i2c/ov9650.c > @@ -1545,8 +1545,8 @@ static int ov965x_remove(struct i2c_client *client) > } > > static const struct i2c_device_id ov965x_id[] = { > - { "OV9650", 0 }, > - { "OV9652", 0 }, > + { "ov9650", 0 }, > + { "ov9652", 0 }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(i2c, ov965x_id);