Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754290AbdGLVZj (ORCPT ); Wed, 12 Jul 2017 17:25:39 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:60908 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754085AbdGLVZh (ORCPT ); Wed, 12 Jul 2017 17:25:37 -0400 From: "Rafael J. Wysocki" To: Lv Zheng Cc: "Rafael J . Wysocki" , Len Brown , Lv Zheng , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Stable # all applicable Subject: Re: [PATCH 1/2] ACPI: EC: Drop EC noirq hooks to fix a regression Date: Wed, 12 Jul 2017 23:17:53 +0200 Message-ID: <1959612.ejQZU5VTTY@aspire.rjw.lan> User-Agent: KMail/4.14.10 (Linux/4.12.0-rc1+; KDE/4.14.9; x86_64; ; ) In-Reply-To: <26498770711bbb36ca2888b33b56a0a56dc29083.1499828705.git.lv.zheng@intel.com> References: <26498770711bbb36ca2888b33b56a0a56dc29083.1499828705.git.lv.zheng@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 28 On Wednesday, July 12, 2017 11:09:09 AM Lv Zheng wrote: > According to the bug report, though the busy polling mode can make noirq > stages executed faster, it causes abnormal fan blowing up after a system > resume (see link #1 for a video demonstration) on Lenovo ThinkPad X1 Carbon > - the 5th Generation. The problem can be fixed by an upgraded EC firmware. > > However many reporters can also confirm that the problem can be fixed by > stopping busy polling during suspend/resume. > > This patch drops noirq stage hooks so that the regression can be fixed > without upgrading the EC firmware. > > Fixes: c3a696b6e8f8 ("ACPI / EC: Use busy polling mode when GPE is not enabled") > Link: https://youtu.be/9NQ9x-Jm99Q [#1] > Link: https://bugzilla.kernel.org/show_bug.cgi?id=196129 > Reported-by: Andreas Lindhe > Tested-by: Gjorgji Jankovski > Tested-by: Damjan Georgievski > Tested-by: Fernando Chaves > Tested-by: Tomislav Ivek > Tested-by: Denis P. > Signed-off-by: Lv Zheng > Cc: Stable # all applicable Both patches applied with some minor modifications in the changelogs. Thanks, Rafael