Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754433AbdGLV06 (ORCPT ); Wed, 12 Jul 2017 17:26:58 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:44383 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753588AbdGLV04 (ORCPT ); Wed, 12 Jul 2017 17:26:56 -0400 From: "Rafael J. Wysocki" To: Mark Salter Cc: Marc Zyngier , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acpi: Fix proper return code for function acpi_gsi_to_irq Date: Wed, 12 Jul 2017 23:19:13 +0200 Message-ID: <3621133.l64SNjHUuW@aspire.rjw.lan> User-Agent: KMail/4.14.10 (Linux/4.12.0-rc1+; KDE/4.14.9; x86_64; ; ) In-Reply-To: <20170711164543.23439-1-msalter@redhat.com> References: <20170711164543.23439-1-msalter@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 754 Lines: 21 On Tuesday, July 11, 2017 12:45:43 PM Mark Salter wrote: > The function acpi_gsi_to_irq must return 0 on success as the caller > ghes_probe expects an 0 for success. This change also matches x86 > implementation. > > This patch was submitted around 4.5 timeframe but wasn't pushed because > it didn't fix a real problem. Now that RAS/GHES patches are in kernel, > this fixes an error seen on a Mustang (arm64) platform: > > GHES: Failed to map GSI to IRQ for generic hardware error source: 2 > GHES: probe of GHES.2 failed with error 81 > > Signed-off-by: Tuan Phan > Signed-off-by: Loc Ho > [rebased to v4.12-rc] > Signed-off-by: Mark Salter Applied with the Lorenzo's ACK. Thanks, Rafael