Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753588AbdGLV5s (ORCPT ); Wed, 12 Jul 2017 17:57:48 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40145 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbdGLV5q (ORCPT ); Wed, 12 Jul 2017 17:57:46 -0400 Date: Wed, 12 Jul 2017 14:57:29 -0700 From: Ram Pai To: Dave Hansen Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, arnd@arndb.de, akpm@linux-foundation.org, corbet@lwn.net, mingo@redhat.com Subject: Re: [RFC v5 36/38] selftest: PowerPC specific test updates to memory protection keys Reply-To: Ram Pai References: <1499289735-14220-1-git-send-email-linuxram@us.ibm.com> <1499289735-14220-37-git-send-email-linuxram@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 17071221-0040-0000-0000-0000037EA71D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007357; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00886678; UDB=6.00442625; IPR=6.00666827; BA=6.00005469; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016202; XFM=3.00000015; UTC=2017-07-12 21:57:43 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17071221-0041-0000-0000-00000772B4D5 Message-Id: <20170712215729.GC5525@ram.oc3035372033.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-12_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707120349 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 25 On Tue, Jul 11, 2017 at 10:33:09AM -0700, Dave Hansen wrote: > On 07/05/2017 02:22 PM, Ram Pai wrote: > > Abstracted out the arch specific code into the header file, and > > added powerpc specific changes. > > > > a) added 4k-backed hpte, memory allocator, powerpc specific. > > b) added three test case where the key is associated after the page is > > accessed/allocated/mapped. > > c) cleaned up the code to make checkpatch.pl happy > > There's a *lot* of churn here. If it breaks, I'm going to have a heck > of a time figuring out which hunk broke. Is there any way to break this > up into a series of things that we have a chance at bisecting? Just finished breaking down the changes into 20 gradual increments. I have pushed it to my github tree at https://github.com/rampai/memorykeys.git branch is memkey.v6-rc3 See if it works for you. I am sure I would have broken something on x86 since I dont have a x86 platform to test. Let me know, Thanks, RP