Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545AbdGLWsD (ORCPT ); Wed, 12 Jul 2017 18:48:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39214 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbdGLWsC (ORCPT ); Wed, 12 Jul 2017 18:48:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5CE647CE0C Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jpoimboe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5CE647CE0C Date: Wed, 12 Jul 2017 17:47:59 -0500 From: Josh Poimboeuf To: Andi Kleen Cc: x86@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Linus Torvalds , Andy Lutomirski , Jiri Slaby , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , Mike Galbraith Subject: Re: [PATCH v3 00/10] x86: ORC unwinder (previously undwarf) Message-ID: <20170712224759.a32747n3oso245ij@treble> References: <87wp7dmgoo.fsf@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87wp7dmgoo.fsf@firstfloor.org> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 12 Jul 2017 22:48:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 694 Lines: 18 On Wed, Jul 12, 2017 at 03:30:31PM -0700, Andi Kleen wrote: > Josh Poimboeuf writes: > > > > The ORC data format does have a few downsides compared to DWARF. The > > ORC unwind tables take up ~1MB more memory than DWARF eh_frame tables. > > > Can we have an option to just use dwarf instead? For people > who don't want to waste a MB+ to solve a problem that doesn't > exist (as proven by many years of opensuse kernel experience) > > As far as I can tell this whole thing has only downsides compared > to the dwarf unwinder that was earlier proposed. I don't see > a single advantage. Improved speed, reliability, maintainability. Are those not advantages? -- Josh