Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751824AbdGLXQM (ORCPT ); Wed, 12 Jul 2017 19:16:12 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:49729 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbdGLXQJ (ORCPT ); Wed, 12 Jul 2017 19:16:09 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Andrei Vagin Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , Linus Torvalds , Al Viro , Oleg Nesterov , Thomas Gleixner , Greg KH , Andrey Vagin , Serge Hallyn , Pavel Emelyanov , Cyrill Gorcunov , Peter Zijlstra , Willy Tarreau , linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Linux Containers , Michael Kerrisk References: <87efu22set.fsf@xmission.com> <20170630123906.8865-8-ebiederm@xmission.com> <20170712223557.GA21885@outlook.office365.com> Date: Wed, 12 Jul 2017 18:08:07 -0500 In-Reply-To: <20170712223557.GA21885@outlook.office365.com> (Andrei Vagin's message of "Wed, 12 Jul 2017 15:36:04 -0700") Message-ID: <87wp7dgso8.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1dVQrP-0000Hk-Rr;;;mid=<87wp7dgso8.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=67.3.213.87;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19RJ217xwj4OUHORr8gwz22F0k5JygyLto= X-SA-Exim-Connect-IP: 67.3.213.87 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Andrei Vagin X-Spam-Relay-Country: X-Spam-Timing: total 5300 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 2.7 (0.1%), b_tie_ro: 1.86 (0.0%), parse: 0.85 (0.0%), extract_message_metadata: 11 (0.2%), get_uri_detail_list: 0.61 (0.0%), tests_pri_-1000: 7 (0.1%), tests_pri_-950: 1.25 (0.0%), tests_pri_-900: 1.05 (0.0%), tests_pri_-400: 18 (0.3%), check_bayes: 17 (0.3%), b_tokenize: 6 (0.1%), b_tok_get_all: 5 (0.1%), b_comp_prob: 1.63 (0.0%), b_tok_touch_all: 2.5 (0.0%), b_finish: 0.67 (0.0%), tests_pri_0: 1154 (21.8%), check_dkim_signature: 0.57 (0.0%), check_dkim_adsp: 2.9 (0.1%), tests_pri_500: 4101 (77.4%), poll_dns_idle: 4095 (77.3%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 8/8] signal: Remove kernel interal si_code magic X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 536 Lines: 17 Andrei Vagin writes: >> diff --git a/arch/tile/kernel/traps.c b/arch/tile/kernel/traps.c >> index 54804866f238..4433d1dc28e6 100644 >> --- a/arch/tile/kernel/traps.c >> +++ b/arch/tile/kernel/traps.c >> @@ -188,7 +188,6 @@ static int special_ill(tile_bundle_bits bundle, int *sigp, int *codep) >> >> /* Make it the requested signal. */ >> *sigp = sig; >> - *codep = code | __SI_FAULT; > > Are you sure that we don't need to set codep here? Looking closely we definitely do. Good catch. Thank you. Eric