Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751235AbdGMAIb (ORCPT ); Wed, 12 Jul 2017 20:08:31 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:35022 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbdGMAI3 (ORCPT ); Wed, 12 Jul 2017 20:08:29 -0400 MIME-Version: 1.0 X-Originating-IP: [209.133.79.7] In-Reply-To: <20170712215517.GA22123@dtor-ws> References: <20170712215517.GA22123@dtor-ws> From: Olof Johansson Date: Wed, 12 Jul 2017 17:08:27 -0700 Message-ID: Subject: Re: Regression during 4.13 merge window: Mouse not working (under X) To: Dmitry Torokhov Cc: "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 32 On Wed, Jul 12, 2017 at 2:55 PM, Dmitry Torokhov wrote: > On Wed, Jul 12, 2017 at 02:45:18PM -0700, Olof Johansson wrote: >> Dmitry, >> >> I installed current mainline (as of 3b06b1a744) on a z840 here, and >> lost the mouse. >> >> Bisecting down, it seems like "HID: usbhid: remove custom locking from >> usbhid_open/close" (e399396a6b0) is at fault, and if I revert that and >> 283a21da1239 I get a working system again. Userspace is Ubuntu 16.04. > > Olof, does the patch below work for you? Yup! Thanks! > -- > Dmitry > > HID: usbhid: fix "always poll" quirk > > From: Dmitry Torokhov > > Even though the IO for devices with "always poll" quirk is already running, > we still need to set HID_OPENED bit in usbhid->iofl so the interrupt > handler does not ignore the data coming from the device. > > Reported-by: Olof Johansson > Fixes: e399396a6b0 ("HID: usbhid: remove custom locking from usbhid_open...") > Signed-off-by: Dmitry Torokhov Tested-by: Olof Johansson