Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751192AbdGMD5z (ORCPT ); Wed, 12 Jul 2017 23:57:55 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57292 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbdGMD5x (ORCPT ); Wed, 12 Jul 2017 23:57:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E73396141F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org Subject: Re: [PATCH V4 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops To: Stephen Boyd References: <1499333825-7658-1-git-send-email-vivek.gautam@codeaurora.org> <1499333825-7658-3-git-send-email-vivek.gautam@codeaurora.org> <20170712225821.GB22780@codeaurora.org> <20170712230152.GC22780@codeaurora.org> Cc: joro@8bytes.org, robin.murphy@arm.com, robh+dt@kernel.org, mark.rutland@arm.com, will.deacon@arm.com, m.szyprowski@samsung.com, robdclark@gmail.com, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, sricharan@codeaurora.org, stanimir.varbanov@linaro.org, architt@codeaurora.org, linux-arm-kernel@lists.infradead.org, Bjorn Andersson From: Vivek Gautam Message-ID: Date: Thu, 13 Jul 2017 09:27:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170712230152.GC22780@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1405 Lines: 40 On 07/13/2017 04:31 AM, Stephen Boyd wrote: > On 07/12, Stephen Boyd wrote: >> On 07/06, Vivek Gautam wrote: >>> From: Sricharan R >>> >>> The smmu needs to be functional only when the respective >>> master's using it are active. The device_link feature >>> helps to track such functional dependencies, so that the >>> iommu gets powered when the master device enables itself >>> using pm_runtime. So by adapting the smmu driver for >>> runtime pm, above said dependency can be addressed. >>> >>> This patch adds the pm runtime/sleep callbacks to the >>> driver and also the functions to parse the smmu clocks >>> from DT and enable them in resume/suspend. >>> >>> Signed-off-by: Sricharan R >>> Signed-off-by: Archit Taneja >>> [vivek: Clock rework to loop over clock names data] >>> Signed-off-by: Vivek Gautam >>> --- >> General comment, we have a bulk clk API now, but I guess we >> failed to add the clk_bulk_prepare_enable() API that could be >> used here. Perhaps you can add that API and then use it here to >> reduce lines of code. Sure, will use the bulk clock APIs to handle the clocks. Best regards Vivek >> > Bjorn just sent a patch for that API an hour ago. > -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project