Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751083AbdGMEzP (ORCPT ); Thu, 13 Jul 2017 00:55:15 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:56145 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbdGMEzO (ORCPT ); Thu, 13 Jul 2017 00:55:14 -0400 Subject: Re: [PATCH v1] spi: loopback-test: provide loop request option. To: Oleksij Rempel , kernel@pengutronix.de, Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170712134020.17927-1-o.rempel@pengutronix.de> Cc: Oleksij Rempel From: Oleksij Rempel Message-ID: Date: Thu, 13 Jul 2017 06:55:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170712134020.17927-1-o.rempel@pengutronix.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:13da X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1730 Lines: 56 On 12.07.2017 15:40, Oleksij Rempel wrote: > From: Oleksij Rempel > > Provide a module parameter to request internal > loop by the SPI master controller. > This should make loop testing easier without extra HW modification. > > Signed-off-by: Oleksij Rempel > --- > drivers/spi/spi-loopback-test.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c > index f4875f177df0..34e1544d7d0e 100644 > --- a/drivers/spi/spi-loopback-test.c > +++ b/drivers/spi/spi-loopback-test.c > @@ -51,6 +51,14 @@ MODULE_PARM_DESC(loopback, > "is checked to match tx_buf after the spi_message " \ > "is executed"); > > +/* the device is jumpered for loopback - enabling some rx_buf tests */ > +int loop_req; > +module_param(loop_req, int, 0); > +MODULE_PARM_DESC(loop_req, > + "if set enable controller will be asked to enable " \ i need to correct this ^^^. And wait if there any other comments :) > + "test loop mode. If supported, MISO and MOSI will be " \ > + "jumpered by SPI controller"); > + > /* run only a specific test */ > int run_only_test = -1; > module_param(run_only_test, int, 0); > @@ -313,6 +321,16 @@ static int spi_loopback_test_probe(struct spi_device *spi) > { > int ret; > > + if (loop_req) { > + spi->mode = SPI_LOOP | spi->mode; > + ret = spi_setup(spi); > + if (ret) { > + dev_err(&spi->dev, "SPI setup wasn't successful %d\n", ret); > + dev_err(&spi->dev, "SPI_LOOP is not supported by SPI master."); > + return -ENODEV; > + } > + } > + > dev_info(&spi->dev, "Executing spi-loopback-tests\n"); > > ret = spi_test_run_tests(spi, spi_tests); >