Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751062AbdGMHgn (ORCPT ); Thu, 13 Jul 2017 03:36:43 -0400 Received: from gateway20.websitewelcome.com ([192.185.50.28]:22678 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbdGMHgl (ORCPT ); Thu, 13 Jul 2017 03:36:41 -0400 Date: Thu, 13 Jul 2017 02:36:38 -0500 Message-ID: <20170713023638.Horde.0_LUC9FWsp9URj4mt2AqTT6@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Takashi Iwai Cc: Timur Tabi , Nicolin Chen , Xiubo Li , Fabio Estevam , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure References: <20170713072351.GA1485@embeddedgus> In-Reply-To: User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dVYfu-000cOR-81 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:19202 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 40 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1707 Lines: 67 Hi Takashi, Quoting Takashi Iwai : > Gustavo, > > please stop posting in this style. It's really annoying to see > spontaneously popping-up almost same patch for more than two hours > long. > > If you have a series of the same fix patches, send them as a patch > set in a shot with a thread. git-send-email does it right. > I will do that. Thanks for the suggestion. -- Gustavo A. R. Silva > I don't mind a couple of patches posted separately, but this is over > the limit. > > > thanks, > > Takashi > > On Thu, 13 Jul 2017 09:23:51 +0200, > Gustavo A. R. Silva wrote: >> >> This structure is only stored in the ops field of a snd_soc_dai_driver >> structure. That field is declared const, so snd_soc_dai_ops structures >> that have this property can be declared as const also. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> sound/soc/fsl/fsl_asrc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c >> index 8cfffa7..806d399 100644 >> --- a/sound/soc/fsl/fsl_asrc.c >> +++ b/sound/soc/fsl/fsl_asrc.c >> @@ -542,7 +542,7 @@ static int fsl_asrc_dai_trigger(struct >> snd_pcm_substream *substream, int cmd, >> return 0; >> } >> >> -static struct snd_soc_dai_ops fsl_asrc_dai_ops = { >> +static const struct snd_soc_dai_ops fsl_asrc_dai_ops = { >> .hw_params = fsl_asrc_dai_hw_params, >> .hw_free = fsl_asrc_dai_hw_free, >> .trigger = fsl_asrc_dai_trigger, >> -- >> 2.5.0 >> >> _______________________________________________ >> Alsa-devel mailing list >> Alsa-devel@alsa-project.org >> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >>