Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbdGMHms (ORCPT ); Thu, 13 Jul 2017 03:42:48 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:55909 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbdGMHmr (ORCPT ); Thu, 13 Jul 2017 03:42:47 -0400 Date: Thu, 13 Jul 2017 09:42:43 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Oleksij Rempel Cc: kernel@pengutronix.de, Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Oleksij Rempel Subject: Re: [PATCH v1] spi: loopback-test: provide loop request option. Message-ID: <20170713074243.lvrxjpt7pfksg4xl@pengutronix.de> References: <20170712134020.17927-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170712134020.17927-1-o.rempel@pengutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:5054:ff:fe2a:3aa X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1912 Lines: 59 On Wed, Jul 12, 2017 at 03:40:20PM +0200, Oleksij Rempel wrote: > From: Oleksij Rempel > > Provide a module parameter to request internal > loop by the SPI master controller. > This should make loop testing easier without extra HW modification. > > Signed-off-by: Oleksij Rempel > --- > drivers/spi/spi-loopback-test.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c > index f4875f177df0..34e1544d7d0e 100644 > --- a/drivers/spi/spi-loopback-test.c > +++ b/drivers/spi/spi-loopback-test.c > @@ -51,6 +51,14 @@ MODULE_PARM_DESC(loopback, > "is checked to match tx_buf after the spi_message " \ > "is executed"); > > +/* the device is jumpered for loopback - enabling some rx_buf tests */ > +int loop_req; > +module_param(loop_req, int, 0); > +MODULE_PARM_DESC(loop_req, > + "if set enable controller will be asked to enable " \ > + "test loop mode. If supported, MISO and MOSI will be " \ > + "jumpered by SPI controller"); > + > /* run only a specific test */ > int run_only_test = -1; > module_param(run_only_test, int, 0); > @@ -313,6 +321,16 @@ static int spi_loopback_test_probe(struct spi_device *spi) > { > int ret; > > + if (loop_req) { > + spi->mode = SPI_LOOP | spi->mode; > + ret = spi_setup(spi); > + if (ret) { > + dev_err(&spi->dev, "SPI setup wasn't successful %d\n", ret); > + dev_err(&spi->dev, "SPI_LOOP is not supported by SPI master."); Why two error messages here? What about: dev_err(&spi->dev, "SPI setup with SPI_LOOP failed (%d)\n", ret); These lines are > 80 chars, so you should break them. > + return -ENODEV; return ret? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |