From: Ran Wang <ran.wang_1@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
CC: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Andy Tang <andy.tang@nxp.com>,
        Harninder Rai <harninder.rai@nxp.com>,
        =?iso-8859-2?Q?Horia_Geant=E3?= <horia.geanta@nxp.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] arm64: dts: ls1012a: add USB host controller nodes
Thread-Topic: [PATCH] arm64: dts: ls1012a: add USB host controller nodes
Thread-Index: AQHS9TxGmoVHP9YG1EypeqaPIFmJxaJRc54AgAAJLoA=
Date: Thu, 13 Jul 2017 08:46:50 +0000
Message-ID: <AM3PR04MB14896986FF8C5A18C2643C29F1AC0@AM3PR04MB1489.eurprd04.prod.outlook.com>
References: <1499223243-13253-1-git-send-email-ran.wang_1@nxp.com>
 <20170713080717.GP3172@dragon>
In-Reply-To: <20170713080717.GP3172@dragon>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-2"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2017 08:46:50.3542
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB1188
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6D8mbVk006528
Content-Length: 2312
Lines: 63

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Thursday, July 13, 2017 4:07 PM
> To: Ran Wang <ran.wang_1@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Catalin Marinas <catalin.marinas@arm.com>; Will
> Deacon <will.deacon@arm.com>; Andy Tang <andy.tang@nxp.com>; Harninder
> Rai <harninder.rai@nxp.com>; Horia Geant? <horia.geanta@nxp.com>; open
> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; moderated list:ARM64 PORT (AARCH64
> ARCHITECTURE) <linux-arm-kernel@lists.infradead.org>; open list <linux-
> kernel@vger.kernel.org>
> Subject: Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes
> 
> On Wed, Jul 05, 2017 at 10:54:03AM +0800, Ran Wang wrote:
> > LS1012A has one USB 3.0(DWC3) controller and one USB 2.0 controller.
> >
> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > index b497ac1..8aa2dcf 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > @@ -411,6 +411,23 @@
> >  				 <&clockgen 4 3>;
> >  		};
> >
> > +		usb0: usb3@2f00000 {
> > +			compatible = "snps,dwc3";
> > +			reg = <0x0 0x2f00000 0x0 0x10000>;
> > +			interrupts = <0 60 0x4>;
> > +			dr_mode = "host";
> > +			snps,quirk-frame-length-adjustment = <0x20>;
> > +			snps,dis_rxdet_inp3_quirk;
> > +		};
> > +
> > +		usb1: usb2@8600000 {
> > +			compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> > +			reg = <0x0 0x8600000 0x0 0x1000>;
> > +			interrupts = <0 139 0x4>;
> > +			dr_mode = "host";
> > +			phy_type = "ulpi";
> > +		};
> 
> Please keep the nodes sorted in unit-address.
> 
> Shawn
Do you mean to move the node 'usb1: usb2@8600000' forward to where it's address is just before  '@8600000 '?
I think it's reasonable to put USB controller nodes together in DTS for developer to do issue analysis.

Ran
> 
> > +
> >  		sata: sata@3200000 {
> >  			compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
> >  			reg = <0x0 0x3200000 0x0 0x10000>,
> > --
> > 2.1.0.27.g96db324
> >