Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751277AbdGMI5i (ORCPT ); Thu, 13 Jul 2017 04:57:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:44894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbdGMI5h (ORCPT ); Thu, 13 Jul 2017 04:57:37 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B29F722C97 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Thu, 13 Jul 2017 16:57:21 +0800 From: Shawn Guo To: Ran Wang Cc: Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Andy Tang , Harninder Rai , Horia =?utf-8?Q?Geant=C4=83?= , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , open list Subject: Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes Message-ID: <20170713085720.GX3172@dragon> References: <1499223243-13253-1-git-send-email-ran.wang_1@nxp.com> <20170713080717.GP3172@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1567 Lines: 47 On Thu, Jul 13, 2017 at 08:46:50AM +0000, Ran Wang wrote: > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > > index b497ac1..8aa2dcf 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > > @@ -411,6 +411,23 @@ > > > <&clockgen 4 3>; > > > }; > > > > > > + usb0: usb3@2f00000 { > > > + compatible = "snps,dwc3"; > > > + reg = <0x0 0x2f00000 0x0 0x10000>; > > > + interrupts = <0 60 0x4>; > > > + dr_mode = "host"; > > > + snps,quirk-frame-length-adjustment = <0x20>; > > > + snps,dis_rxdet_inp3_quirk; > > > + }; > > > + > > > + usb1: usb2@8600000 { > > > + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr"; > > > + reg = <0x0 0x8600000 0x0 0x1000>; > > > + interrupts = <0 139 0x4>; > > > + dr_mode = "host"; > > > + phy_type = "ulpi"; > > > + }; > > > > Please keep the nodes sorted in unit-address. > > > > Shawn > Do you mean to move the node 'usb1: usb2@8600000' forward to where it's address is just before '@8600000 '? > I think it's reasonable to put USB controller nodes together in DTS for developer to do issue analysis. The nodes under simple-bus are maintained in order of unit-address. Please respect that. usb2@8600000 should go after sata@3200000 with the current nodes. Shawn > > > + > > > sata: sata@3200000 { > > > compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci"; > > > reg = <0x0 0x3200000 0x0 0x10000>, > > > -- > > > 2.1.0.27.g96db324 > > >