Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751363AbdGMJVF (ORCPT ); Thu, 13 Jul 2017 05:21:05 -0400 Received: from www62.your-server.de ([213.133.104.62]:47407 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbdGMJVE (ORCPT ); Thu, 13 Jul 2017 05:21:04 -0400 Message-ID: <59673B7A.2080606@iogearbox.net> Date: Thu, 13 Jul 2017 11:20:58 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Kefeng Wang , Alexei Starovoitov , "David S. Miller" CC: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] bpf: fix return in bpf_skb_adjust_net References: <1499927278-175876-1-git-send-email-wangkefeng.wang@huawei.com> In-Reply-To: <1499927278-175876-1-git-send-email-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 310 Lines: 9 On 07/13/2017 08:27 AM, Kefeng Wang wrote: > The bpf_skb_adjust_net() ignores the return value of bpf_skb_net_shrink/grow, > and always return 0, fix it by return 'ret'. > > Signed-off-by: Kefeng Wang Sigh, yep of course. Thanks! Acked-by: Daniel Borkmann