Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751977AbdGMJwb (ORCPT ); Thu, 13 Jul 2017 05:52:31 -0400 Received: from terminus.zytor.com ([65.50.211.136]:53707 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbdGMJwV (ORCPT ); Thu, 13 Jul 2017 05:52:21 -0400 Date: Thu, 13 Jul 2017 02:48:42 -0700 From: tip-bot for Alex Shi Message-ID: Cc: bigeasy@linutronix.de, alex.shi@linaro.org, juri.lelli@arm.com, tglx@linutronix.de, rostedt@goodmis.org, peterz@infradead.org, mathieu.poirier@linaro.org, hpa@zytor.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org Reply-To: bigeasy@linutronix.de, alex.shi@linaro.org, juri.lelli@arm.com, rostedt@goodmis.org, tglx@linutronix.de, peterz@infradead.org, mathieu.poirier@linaro.org, torvalds@linux-foundation.org, hpa@zytor.com, mingo@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <1499926704-28841-1-git-send-email-alex.shi@linaro.org> References: <1499926704-28841-1-git-send-email-alex.shi@linaro.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/urgent] locking/rtmutex: Remove unnecessary priority adjustment Git-Commit-ID: 69f0d429c413fe96db2c187475cebcc6e3a8c7f5 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1850 Lines: 48 Commit-ID: 69f0d429c413fe96db2c187475cebcc6e3a8c7f5 Gitweb: http://git.kernel.org/tip/69f0d429c413fe96db2c187475cebcc6e3a8c7f5 Author: Alex Shi AuthorDate: Thu, 13 Jul 2017 14:18:24 +0800 Committer: Ingo Molnar CommitDate: Thu, 13 Jul 2017 11:44:06 +0200 locking/rtmutex: Remove unnecessary priority adjustment We don't need to adjust priority before adding a new pi_waiter, the priority only needs to be updated after pi_waiter change or task priority change. Steven Rostedt pointed out: "Interesting, I did some git mining and this was added with the original entry of the rtmutex.c (23f78d4a03c5). Looking at even that version, I don't see the purpose of adjusting the task prio here. It is done before anything changes in the task." Signed-off-by: Alex Shi Reviewed-by: Steven Rostedt (VMware) Acked-by: Peter Zijlstra (Intel) Cc: Juri Lelli Cc: Linus Torvalds Cc: Mathieu Poirier Cc: Sebastian Siewior Cc: Steven Rostedt Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1499926704-28841-1-git-send-email-alex.shi@linaro.org [ Enhance the changelog. ] Signed-off-by: Ingo Molnar --- kernel/locking/rtmutex.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index 7806989..649dc9d 100644 --- a/kernel/locking/rtmutex.c +++ b/kernel/locking/rtmutex.c @@ -963,7 +963,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock, return -EDEADLK; raw_spin_lock(&task->pi_lock); - rt_mutex_adjust_prio(task); waiter->task = task; waiter->lock = lock; waiter->prio = task->prio;