Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751997AbdGMMhC (ORCPT ); Thu, 13 Jul 2017 08:37:02 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35956 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbdGMMhB (ORCPT ); Thu, 13 Jul 2017 08:37:01 -0400 Date: Thu, 13 Jul 2017 14:36:55 +0200 From: Daniel Vetter To: Jeffy Chen , Linus Torvalds , Dave Airlie Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, Daniel Vetter Subject: Re: [PATCH] drm: Add missing field copy in compat_drm_version Message-ID: <20170713123655.n56qor3hq7jqt33h@phenom.ffwll.local> Mail-Followup-To: Jeffy Chen , Linus Torvalds , Dave Airlie , linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, Daniel Vetter References: <1499840312-23418-1-git-send-email-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499840312-23418-1-git-send-email-jeffy.chen@rock-chips.com> X-Operating-System: Linux phenom 4.11.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1604 Lines: 51 On Wed, Jul 12, 2017 at 02:18:32PM +0800, Jeffy Chen wrote: > DRM_IOCTL_VERSION is supposed to update the name_len/date_len/desc_len > fields to user. > > Fixes: 012c6741c6aa("switch compat_drm_version() to drm_ioctl_kernel()") > Signed-off-by: Jeffy Chen Reviewed-by: Daniel Vetter Linus, since Dave is a bit out with flu and this bug only exists in your tree (not yet in drm-next), can you pls apply this directly? It's a fumble in Al's rework. Direct mbox link from patchwork, in case you don't have that in your archives anywhere: https://patchwork.freedesktop.org/patch/166318/mbox/ Thanks, Daniel > > --- > > drivers/gpu/drm/drm_ioc32.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c > index 94acf51..2789356 100644 > --- a/drivers/gpu/drm/drm_ioc32.c > +++ b/drivers/gpu/drm/drm_ioc32.c > @@ -112,6 +112,9 @@ static int compat_drm_version(struct file *file, unsigned int cmd, > v32.version_major = v.version_major; > v32.version_minor = v.version_minor; > v32.version_patchlevel = v.version_patchlevel; > + v32.name_len = v.name_len; > + v32.date_len = v.date_len; > + v32.desc_len = v.desc_len; > if (copy_to_user((void __user *)arg, &v32, sizeof(v32))) > return -EFAULT; > return 0; > -- > 2.1.4 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch