Message-ID: <1499949850.4826.88.camel@rf-debian.wolfsonmicro.main>
Subject: Re: [PATCH v2 01/18] mfd: madera: Add register definitions for
 Cirrus Logic Madera codecs
From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
CC: Lee Jones <lee.jones@linaro.org>, <linus.walleij@linaro.org>,
        <gnurou@gmail.com>, <robh+dt@kernel.org>, <tglx@linutronix.de>,
        <jason@lakedaemon.net>, <alsa-devel@alsa-project.org>,
        <patches@opensource.wolfsonmicro.com>, <linux-gpio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Date: Thu, 13 Jul 2017 13:44:10 +0100
In-Reply-To: <20170713100539.mqvyxgvwqowjim6i@sirena.org.uk>
References: <1493050124-5970-1-git-send-email-rf@opensource.wolfsonmicro.com>
         <1493050124-5970-2-git-send-email-rf@opensource.wolfsonmicro.com>
         <20170713080210.lbsjnmlciovoxe4g@dell>
         <20170713100539.mqvyxgvwqowjim6i@sirena.org.uk>
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 728
Lines: 17


On Thu, 2017-07-13 at 11:05 +0100, Mark Brown wrote:
> On Thu, Jul 13, 2017 at 09:02:10AM +0100, Lee Jones wrote:
> 
> > This patch has been rejected by Linus.
> 
> > https://lkml.org/lkml/2017/7/7/579
> 
> Hrm, when I used to push the register definition patches I did elide all
> the obviously repeated register banks like the write sequencer one that
> Linus is calling out there.  I'm surprised by the "every single line"
> bit though...

Linux doesn't say what he wants us to do about it. I could manually
strip out a few more definitions but seriously, it makes the code a lot
harder to maintain if we can't grep it for use of registers and register
fields. They are big chips, they have a lot of stuff in the registers.