Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbdGMND0 (ORCPT ); Thu, 13 Jul 2017 09:03:26 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:38894 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752332AbdGMNDY (ORCPT ); Thu, 13 Jul 2017 09:03:24 -0400 Date: Thu, 13 Jul 2017 14:03:05 +0100 From: Mark Brown To: Richard Fitzgerald Cc: Lee Jones , linus.walleij@linaro.org, gnurou@gmail.com, robh+dt@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20170713130305.ytrk322lqe6dusla@sirena.org.uk> References: <1493050124-5970-1-git-send-email-rf@opensource.wolfsonmicro.com> <1493050124-5970-2-git-send-email-rf@opensource.wolfsonmicro.com> <20170713080210.lbsjnmlciovoxe4g@dell> <20170713100539.mqvyxgvwqowjim6i@sirena.org.uk> <1499949850.4826.88.camel@rf-debian.wolfsonmicro.main> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dnu4nyp3x6jvsw2v" Content-Disposition: inline In-Reply-To: <1499949850.4826.88.camel@rf-debian.wolfsonmicro.main> X-Cookie: Hindsight is an exact science. User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 01/18] mfd: madera: Add register definitions for Cirrus Logic Madera codecs X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1830 Lines: 47 --dnu4nyp3x6jvsw2v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 13, 2017 at 01:44:10PM +0100, Richard Fitzgerald wrote: > On Thu, 2017-07-13 at 11:05 +0100, Mark Brown wrote: > > On Thu, Jul 13, 2017 at 09:02:10AM +0100, Lee Jones wrote: > > > This patch has been rejected by Linus. > > > https://lkml.org/lkml/2017/7/7/579 > > Hrm, when I used to push the register definition patches I did elide all > > the obviously repeated register banks like the write sequencer one that > > Linus is calling out there. I'm surprised by the "every single line" > > bit though... > Linux doesn't say what he wants us to do about it. I could manually > strip out a few more definitions but seriously, it makes the code a lot > harder to maintain if we can't grep it for use of registers and register > fields. They are big chips, they have a lot of stuff in the registers. I'd take it up with him, if you can explain why it looks very repetitive but isn't actually that'd help... Building up copies of the repeated IPs with macros would help too (the AIF and especially frame control registers stick out like a sore thumb here), as would removing the individual registers for the write sequencer block. --dnu4nyp3x6jvsw2v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAllnb4gACgkQJNaLcl1U h9Ajzwf/UT3dCb8Miwi/swDRP0ZvxT512f4vbdv9H1+mx+lXkUUQ3xQOYHvfy2Fp 7qnitYjeGzzPk5Qm5sfkEHDgmm95Ju3OKAPQqsib0qYHRIWQ1Tbfk9/USplc6oqb TyKqII498Tt1t5Uq4ZmjVynwGweem1Hy2TqnjqOgsc9jtRB9mcvup/BFGDwY2Tq6 T/9Wudte3/BkK2Pd9tUUAT+lSHnukOi6lmCdfM+bYJhF8aveEm4ZAzvrhHTETu/E tcn7GcbK5hjMwBaQGtOdJioYdvYJd4CbWSmG8Qb1y+CiTkXcvKZaG/KtNe7TJRhV RuvJHVmYXTilhvtTxIKvkBnbmvB8Uw== =pWIf -----END PGP SIGNATURE----- --dnu4nyp3x6jvsw2v--