Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdGMNGz (ORCPT ); Thu, 13 Jul 2017 09:06:55 -0400 Received: from verein.lst.de ([213.95.11.211]:33866 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbdGMNGy (ORCPT ); Thu, 13 Jul 2017 09:06:54 -0400 Date: Thu, 13 Jul 2017 15:06:52 +0200 From: Christoph Hellwig To: Sagi Grimberg Cc: Johannes Thumshirn , Christoph Hellwig , Keith Busch , mwilck@suse.de, Linux Kernel Mailinglist , Linux NVMe Mailinglist Subject: Re: [PATCH] nvmet: preserve controller serial number between reboots Message-ID: <20170713130652.GA24376@lst.de> References: <20170713104806.12353-1-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 311 Lines: 6 On Thu, Jul 13, 2017 at 03:30:39PM +0300, Sagi Grimberg wrote: > It seems weird that a subsystem has a serial. But that's actually how NVMe defines them. Which mean we first need to fix our code to generate a serial number per subsystem, and on top of that the patch from Johannes seems perfectly reasonable.