Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbdGMNLZ (ORCPT ); Thu, 13 Jul 2017 09:11:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:34358 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751244AbdGMNLY (ORCPT ); Thu, 13 Jul 2017 09:11:24 -0400 Date: Thu, 13 Jul 2017 15:11:21 +0200 From: Johannes Thumshirn To: Christoph Hellwig Cc: Sagi Grimberg , Keith Busch , mwilck@suse.de, Linux Kernel Mailinglist , Linux NVMe Mailinglist Subject: Re: [PATCH] nvmet: preserve controller serial number between reboots Message-ID: <20170713131121.GJ5212@linux-x5ow.site> References: <20170713104806.12353-1-jthumshirn@suse.de> <20170713130652.GA24376@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170713130652.GA24376@lst.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 763 Lines: 17 On Thu, Jul 13, 2017 at 03:06:52PM +0200, Christoph Hellwig wrote: > On Thu, Jul 13, 2017 at 03:30:39PM +0300, Sagi Grimberg wrote: > > It seems weird that a subsystem has a serial. > > But that's actually how NVMe defines them. Which mean we first > need to fix our code to generate a serial number per subsystem, > and on top of that the patch from Johannes seems perfectly reasonable. Well no problem, I can easily add that. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850