Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbdGMOTO (ORCPT ); Thu, 13 Jul 2017 10:19:14 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:10676 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752435AbdGMOTM (ORCPT ); Thu, 13 Jul 2017 10:19:12 -0400 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 13 Jul 2017 07:19:10 -0700 Subject: Re: [PATCH] ASoC: tegra: constify snd_soc_dai_ops structure To: "Gustavo A. R. Silva" , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Thierry Reding CC: , , References: <20170713054735.GA18162@embeddedgus> From: Jon Hunter Message-ID: <955f62ce-258c-9fa1-9b36-e7a3a8c194dc@nvidia.com> Date: Thu, 13 Jul 2017 15:19:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170713054735.GA18162@embeddedgus> X-Originating-IP: [10.21.132.162] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 32 On 13/07/17 06:47, Gustavo A. R. Silva wrote: > This structure is only stored in the ops field of a snd_soc_dai_driver > structure. That field is declared const, so snd_soc_dai_ops structures > that have this property can be declared as const also. > > Signed-off-by: Gustavo A. R. Silva > --- > sound/soc/tegra/tegra30_i2s.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c > index b2b279c..0b176ea 100644 > --- a/sound/soc/tegra/tegra30_i2s.c > +++ b/sound/soc/tegra/tegra30_i2s.c > @@ -275,7 +275,7 @@ static int tegra30_i2s_probe(struct snd_soc_dai *dai) > return 0; > } > > -static struct snd_soc_dai_ops tegra30_i2s_dai_ops = { > +static const struct snd_soc_dai_ops tegra30_i2s_dai_ops = { > .set_fmt = tegra30_i2s_set_fmt, > .hw_params = tegra30_i2s_hw_params, > .trigger = tegra30_i2s_trigger, Acked-by: Jon Hunter Cheers Jon -- nvpublic