DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C83BC83F46
Subject: Re: [PATCH v4 3/3] KVM: nVMX: Emulate EPTP switching for the L1
 hypervisor
To: Bandan Das <bsd@redhat.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, linux-kernel@vger.kernel.org
References: <20170710204936.4001-1-bsd@redhat.com>
 <20170710204936.4001-4-bsd@redhat.com>
 <2d50ebc4-9328-ce08-b55b-6a331ee13cc3@redhat.com>
 <jpgy3ruam9i.fsf@linux.bootlegged.copy>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <8c58f57d-091f-103d-5d8c-fc49b9d00e13@redhat.com>
Date: Thu, 13 Jul 2017 17:39:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <jpgy3ruam9i.fsf@linux.bootlegged.copy>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 816
Lines: 25

>>> +	/*
>>> +	 * If the (L2) guest does a vmfunc to the currently
>>> +	 * active ept pointer, we don't have to do anything else
>>> +	 */
>>> +	if (vmcs12->ept_pointer != address) {
>>> +		if (address >> cpuid_maxphyaddr(vcpu) ||
>>> +		    !IS_ALIGNED(address, 4096))
>>
>> Couldn't the pfn still be invalid and make kvm_mmu_reload() fail?
>> (triggering a KVM_REQ_TRIPLE_FAULT)
> 
> If there's a triple fault, I think it's a good idea to inject it
> back. Basically, there's no need to take care of damage control
> that L1 is intentionally doing.

I quickly rushed over the massive amount of comments. Sounds like you'll
be preparing a v5. Would be great if you could add some comments that
were the result of this discussion (for parts that are not that obvious
- triple faults) - thanks!

-- 

Thanks,

David