Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752582AbdGMQWS (ORCPT ); Thu, 13 Jul 2017 12:22:18 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:47148 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbdGMQWQ (ORCPT ); Thu, 13 Jul 2017 12:22:16 -0400 Date: Thu, 13 Jul 2017 09:22:15 -0700 (PDT) Message-Id: <20170713.092215.720040460171963059.davem@davemloft.net> To: tsbogend@alpha.franken.de Cc: isubramanian@apm.com, kchudgar@apm.com, qnguyen@apm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces From: David Miller In-Reply-To: <20170713092144.31751508094@solo.franken.de> References: <20170713092144.31751508094@solo.franken.de> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 13 Jul 2017 09:22:16 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 27 From: Thomas Bogendoerfer Date: Thu, 13 Jul 2017 10:57:40 +0200 > From: Thomas Bogendoerfer > > This change fixes following problem > > [ 1.827940] xgene-enet: probe of 1f210030.ethernet failed with error -2 > > which leads to a missing ethernet interface (reproducable at least on > Gigabyte MP30-AR0 and APM Mustang systems). > > The check for a valid clk resource fails, because DT doesn't provide a > clock for sgenet1. But the driver doesn't use this clk, if the ethernet > port is connected via SGMII. Therefore this patch avoids probing for clk > on SGMII interfaces. Applied, thanks. > Fixes: 9aea7779b764 drivers: net: xgene: Fix crash on DT systems Please put the commit header text inside of parenthesis and double quotes, like this: Fixes: 9aea7779b764 ("drivers: net: xgene: Fix crash on DT systems") I fixed it up for you this time.