Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752548AbdGMQ2f (ORCPT ); Thu, 13 Jul 2017 12:28:35 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:47194 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787AbdGMQYo (ORCPT ); Thu, 13 Jul 2017 12:24:44 -0400 Date: Thu, 13 Jul 2017 09:24:32 -0700 (PDT) Message-Id: <20170713.092432.1028640160021503815.davem@davemloft.net> To: colin.king@canonical.com Cc: Yuval.Mintz@cavium.com, ariel.elior@cavium.com, everest-linux-l2@cavium.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: broadcom: bnx2x: make a couple of const arrays static From: David Miller In-Reply-To: <20170711105223.14024-1-colin.king@canonical.com> References: <20170711105223.14024-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 13 Jul 2017 09:24:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 577 Lines: 19 From: Colin King Date: Tue, 11 Jul 2017 11:52:23 +0100 > From: Colin Ian King > > Don't populate various tables on the stack but make them static const. > Makes the object code smaller by nearly 200 bytes: > > Before: > text data bss dec hex filename > 113468 11200 0 124668 1e6fc bnx2x_ethtool.o > > After: > text data bss dec hex filename > 113129 11344 0 124473 1e639 bnx2x_ethtool.o > > Signed-off-by: Colin Ian King Applied.