Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752364AbdGMQib (ORCPT ); Thu, 13 Jul 2017 12:38:31 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32893 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbdGMQia (ORCPT ); Thu, 13 Jul 2017 12:38:30 -0400 Subject: Re: [PATCH] nvmet: preserve controller serial number between reboots To: Christoph Hellwig Cc: Johannes Thumshirn , Keith Busch , mwilck@suse.de, Linux Kernel Mailinglist , Linux NVMe Mailinglist References: <20170713104806.12353-1-jthumshirn@suse.de> <20170713130652.GA24376@lst.de> From: Sagi Grimberg Message-ID: <5b7b436c-eed1-d731-50be-0733f9ac7155@grimberg.me> Date: Thu, 13 Jul 2017 19:38:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170713130652.GA24376@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 323 Lines: 12 >> It seems weird that a subsystem has a serial. > > But that's actually how NVMe defines them. Where is that wording? > Which mean we first > need to fix our code to generate a serial number per subsystem, > and on top of that the patch from Johannes seems perfectly reasonable. If that is indeed the case then sure.