Subject: Re: [PATCH 3/4] perf annotate: Support --show-nr-samples option
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
        Milian Wolff <milian.wolff@kdab.com>, Jiri Olsa <jolsa@redhat.com>
References: <1499811254-9354-1-git-send-email-treeze.taeung@gmail.com>
 <20170712201345.GS27350@kernel.org>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <85aed582-df2f-af7d-0704-7291e7e2d0a9@gmail.com>
Date: Fri, 14 Jul 2017 02:10:40 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170712201345.GS27350@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1104
Lines: 36


On 07/13/2017 05:13 AM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 12, 2017 at 07:14:14AM +0900, Taeung Song escreveu:
>> Add --show-nr-samples option to perf-annotate
>> so that it corresponds with perf-report.
>> Additionally h->sum is properly renamed h->nr_samples.
> 
> Please first do a patch renaming ->sum to ->nr_samples, then a patch
> supportign --show-nr-samples.
> 
> We can have this new --show-nr-samples option, but perhaps the best way
> would be to have a hotkey (I guess we have for period, right) for this?
> 

You mean we need to add a hotkey for --show-nr-samples on the anntoate 
TUI browser,
right ? I added a 'e' hotkey in other patch, not this patch
Change it ?

> At some point would be good to have some 'S' or other hotkey to save the > current set of output modifiers (nr-samples column, period column, etc)
> in the .perfconfig file.

I don't understand what you said..
Is related a hotkey with things in .perfconfig file ?
I thought hotkeys exist on only annotate TUI browser..
You mean the short option for --show-nr-samples ?

Thanks,
Taeung

> 
> - Arnaldo


SNIP