Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbdGMRK7 (ORCPT ); Thu, 13 Jul 2017 13:10:59 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:36525 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbdGMRK5 (ORCPT ); Thu, 13 Jul 2017 13:10:57 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:5640:0:960b:2678:e223:c1c6] In-Reply-To: References: <20170707054849.GA16959@displaylink.com> From: Daniel Vetter Date: Thu, 13 Jul 2017 19:10:55 +0200 X-Google-Sender-Auth: 14wBsDREC_qaUeV4KvhnWzxhJyM Message-ID: Subject: Re: [PATCH] drm/udl: Make page_flip asynchronous To: =?UTF-8?Q?St=C3=A9phane_Marchesin?= Cc: Dawid Kurek , Dave Airlie , Linux Kernel Mailing List , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6DHB3Va004800 Content-Length: 1104 Lines: 23 On Thu, Jul 13, 2017 at 6:25 PM, Stéphane Marchesin wrote: >> Can't we roll this driver over to the atomic helpers instead? There >> you get nonblocking pretty much for free ... I'm not sure extending >> the old modeset code has all that much benefit really. > > This code certainly has value by itself; it makes the driver more > efficient. I think the best can sometimes be the enemy of the good -- > this code is here and written, but I don't think any of us is going to > tackle atomic for udl. Sure, I guess I should have clarified this with "If you want me to review and merge this, then pls look into atomic, since that seems actually beneficial for my own interest". I'm not paid by intel to review driver patches at random, but to keep overall drm in nice shape. Moving drivers to atomic and using more shared infrastructure is in that interest, reviewing random driver patches isn't. Sorry for not making clear, I kinda have that as my implicit context. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch