Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752188AbdGMRR6 (ORCPT ); Thu, 13 Jul 2017 13:17:58 -0400 Received: from verein.lst.de ([213.95.11.211]:35119 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbdGMRR5 (ORCPT ); Thu, 13 Jul 2017 13:17:57 -0400 Date: Thu, 13 Jul 2017 19:17:55 +0200 From: Christoph Hellwig To: Sagi Grimberg Cc: Christoph Hellwig , Johannes Thumshirn , Keith Busch , mwilck@suse.de, Linux Kernel Mailinglist , Linux NVMe Mailinglist Subject: Re: [PATCH] nvmet: preserve controller serial number between reboots Message-ID: <20170713171755.GB5107@lst.de> References: <20170713104806.12353-1-jthumshirn@suse.de> <20170713130652.GA24376@lst.de> <5b7b436c-eed1-d731-50be-0733f9ac7155@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b7b436c-eed1-d731-50be-0733f9ac7155@grimberg.me> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 468 Lines: 14 On Thu, Jul 13, 2017 at 07:38:27PM +0300, Sagi Grimberg wrote: > >>> It seems weird that a subsystem has a serial. >> >> But that's actually how NVMe defines them. > > Where is that wording? Right there in the SN field description: "Serial Number (SN): Contains the serial number for the NVM subsystem that is assigned by the vendor as an ASCII string. Refer to section 7.10 for unique identifier requirements. Refer to section 1.5 for ASCII string requirements"