Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503AbdGMRWd (ORCPT ); Thu, 13 Jul 2017 13:22:33 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35508 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbdGMRWb (ORCPT ); Thu, 13 Jul 2017 13:22:31 -0400 Subject: Re: [PATCH v5 1/2] clk: gate: expose clk_gate_ops::is_enabled To: gabriel.fernandez@st.com, Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre Torgue , Michael Turquette , Stephen Boyd , Nicolas Pitre , Arnd Bergmann , daniel.thompson@linaro.org, andrea.merello@gmail.com, radoslaw.pietrzyk@gmail.com, Lee Jones Cc: devicetree@vger.kernel.org, amelie.delaunay@st.com, olivier.bideau@st.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, gabriel.fernandez.st@gmail.com, linux-arm-kernel@lists.infradead.org, ludovic.barre@st.com References: <1499954552-20075-1-git-send-email-gabriel.fernandez@st.com> <1499954552-20075-2-git-send-email-gabriel.fernandez@st.com> From: Florian Fainelli Message-ID: Date: Thu, 13 Jul 2017 10:22:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1499954552-20075-2-git-send-email-gabriel.fernandez@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1637 Lines: 49 On 07/13/2017 07:02 AM, gabriel.fernandez@st.com wrote: > From: Gabriel Fernandez > > This patch exposes clk_gate_ops::is_enabled as functions > that can be directly called and assigned in places like this so > we don't need wrapper functions that do nothing besides forward > the call. > > Signed-off-by: Gabriel Fernandez > Sugested by Stephen Boyd > --- > drivers/clk/clk-gate.c | 2 +- > include/linux/clk-provider.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-gate.c b/drivers/clk/clk-gate.c > index 4e0c054a..e27e28f 100644 > --- a/drivers/clk/clk-gate.c > +++ b/drivers/clk/clk-gate.c > @@ -86,7 +86,7 @@ static void clk_gate_disable(struct clk_hw *hw) > clk_gate_endisable(hw, 0); > } > > -static int clk_gate_is_enabled(struct clk_hw *hw) > +int clk_gate_is_enabled(struct clk_hw *hw) > { > u32 reg; > struct clk_gate *gate = to_clk_gate(hw); Don't you need to add an EXPORT_SYMBOL_GPL(clk_gate_is_enabled) as well in case this gets used by modules? > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h > index c59c625..e9587ab 100644 > --- a/include/linux/clk-provider.h > +++ b/include/linux/clk-provider.h > @@ -343,6 +343,7 @@ struct clk_hw *clk_hw_register_gate(struct device *dev, const char *name, > u8 clk_gate_flags, spinlock_t *lock); > void clk_unregister_gate(struct clk *clk); > void clk_hw_unregister_gate(struct clk_hw *hw); > +int clk_gate_is_enabled(struct clk_hw *hw); > > struct clk_div_table { > unsigned int val; > -- Florian