Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752806AbdGMSah (ORCPT ); Thu, 13 Jul 2017 14:30:37 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36192 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbdGMSag (ORCPT ); Thu, 13 Jul 2017 14:30:36 -0400 Date: Thu, 13 Jul 2017 11:30:34 -0700 (PDT) X-Google-Original-Date: Thu, 13 Jul 2017 11:01:22 PDT (-0700) Subject: Re: [PATCH 02/17] pci: Add a generic, weakly-linked pcibios_align_resource In-Reply-To: <20170712225042.GL14614@bhelgaas-glaptop.roam.corp.google.com> CC: Olof Johansson , Arnd Bergmann , akpm@linux-foundation.org, albert@sifive.com, yamada.masahiro@socionext.com, mmarek@suse.com, will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com, mingo@redhat.com, daniel.lezcano@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net, mchehab@kernel.org, sfr@canb.auug.org.au, fweisbec@gmail.com, viro@zeniv.linux.org.uk, mcgrof@kernel.org, dledford@redhat.com, bart.vanassche@sandisk.com, sstabellini@kernel.org, daniel.vetter@ffwll.ch, mpe@ellerman.id.au, msalter@redhat.com, nicolas.dichtel@6wind.com, james.hogan@imgtec.com, paul.gortmaker@windriver.com, linux@roeck-us.net, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org, patches@groups.riscv.org From: Palmer Dabbelt To: helgaas@kernel.org Message-ID: Mime-Version: 1.0 (MHng) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1645 Lines: 34 On Wed, 12 Jul 2017 15:50:42 PDT (-0700), helgaas@kernel.org wrote: > On Tue, Jul 11, 2017 at 06:31:15PM -0700, Palmer Dabbelt wrote: >> Multiple architectures define this as trivial function, and I'm adding >> another one as part of the RISC-V port. This adds a __weak version of >> pcibios_align_resource and deletes the now obselete ones in a handful of >> ports. >> >> The only functional change should be that a handful of ports used to >> export pcibios_fixup_bus. Only some architectures export this, so I >> just dropped it. >> >> Signed-off-by: Palmer Dabbelt >> --- >> arch/arc/kernel/pcibios.c | 13 ------------- >> arch/arm64/kernel/pci.c | 17 ----------------- >> arch/ia64/pci/pci.c | 7 ------- >> arch/microblaze/pci/pci-common.c | 7 ------- >> arch/sparc/kernel/leon_pci.c | 6 ------ >> arch/sparc/kernel/pci.c | 10 ---------- >> arch/sparc/kernel/pcic.c | 6 ------ >> arch/tile/kernel/pci.c | 10 ---------- >> arch/tile/kernel/pci_gx.c | 9 --------- >> drivers/pci/setup-res.c | 12 ++++++++++++ >> 10 files changed, 12 insertions(+), 85 deletions(-) > > I think you're making your life harder by including these cleanup > patches in your RISC-V support. This patch makes sense (after sorting > out the issues Luis pointed out), but I think the simplest thing to > expedite merging is to add the empty stubs for RISC-V like everybody > else does, then come back after RISC-V gets merged and do the cleanup. > Then the cleanup clearly goes via the PCI tree and isn't entangled > with anything else. Works for me.