Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbdGMUYh (ORCPT ); Thu, 13 Jul 2017 16:24:37 -0400 Received: from smtp.opengridcomputing.com ([72.48.136.20]:55934 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753201AbdGMUYf (ORCPT ); Thu, 13 Jul 2017 16:24:35 -0400 From: "Steve Wise" To: "'Mustafa Ismail'" , Cc: , , , , References: <1499974658-6180-1-git-send-email-mustafa.ismail@intel.com> <1499974658-6180-2-git-send-email-mustafa.ismail@intel.com> In-Reply-To: <1499974658-6180-2-git-send-email-mustafa.ismail@intel.com> Subject: RE: [PATCH 1/2] RDMA/uverbs: Fix the check for port number Date: Thu, 13 Jul 2017 15:24:39 -0500 Message-ID: <01a201d2fc16$0dd293f0$2977bbd0$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQFi9M5bKF273wXLKUOHGzSXKvEfegCOjJMOoy3N9WA= Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 377 Lines: 10 > The port number is only valid if IB_QP_PORT is set in the mask. > So only check port number if it is valid to prevent modify_qp from > failing due to an invalid port number. > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds") > Signed-off-by: Mustafa Ismail Looks good. Reviewed-by: Steve Wise