Date: Wed, 18 Jun 2003 17:20:07 -0700
From: Chris Wright <chris@wirex.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] PCI device list locking - take 2
Message-ID: <20030618172007.C20182@figure1.int.wirex.com>
Mail-Followup-To: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
References: <20030618212921.GA1807@kroah.com> <20030618153324.A20212@figure1.int.wirex.com> <20030618224609.GB2215@kroah.com> <20030618163237.A21050@figure1.int.wirex.com> <20030618235232.GA2667@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20030618235232.GA2667@kroah.com>; from greg@kroah.com on Wed, Jun 18, 2003 at 04:52:32PM -0700
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 896
Lines: 21

* Greg KH (greg@kroah.com) wrote:
> On Wed, Jun 18, 2003 at 04:32:37PM -0700, Chris Wright wrote:
> > I'm not sure testing a valid ->next makes sense.  It could be non-NULL,
> > but poison, or if it was using list_del_init, it would be stuck in loop.
> 
> When we take the devices off of the list, after list_del(), still under
> the lock, we can null out the list pointers.  Then, later under the
> lock, we can check the pointer before we move to it.  We aren't doing
> fancy list_* functions with the pci device lists at all.

Ah, ok, that should work.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/