Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbdGNBQP (ORCPT ); Thu, 13 Jul 2017 21:16:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47212 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298AbdGNBQM (ORCPT ); Thu, 13 Jul 2017 21:16:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4EE83607CB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 13 Jul 2017 18:16:10 -0700 From: Stephen Boyd To: Florian Fainelli Cc: gabriel.fernandez@st.com, Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre Torgue , Michael Turquette , Nicolas Pitre , Arnd Bergmann , daniel.thompson@linaro.org, andrea.merello@gmail.com, radoslaw.pietrzyk@gmail.com, Lee Jones , devicetree@vger.kernel.org, amelie.delaunay@st.com, olivier.bideau@st.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, gabriel.fernandez.st@gmail.com, linux-arm-kernel@lists.infradead.org, ludovic.barre@st.com Subject: Re: [PATCH v5 1/2] clk: gate: expose clk_gate_ops::is_enabled Message-ID: <20170714011610.GF22780@codeaurora.org> References: <1499954552-20075-1-git-send-email-gabriel.fernandez@st.com> <1499954552-20075-2-git-send-email-gabriel.fernandez@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1524 Lines: 41 On 07/13, Florian Fainelli wrote: > On 07/13/2017 07:02 AM, gabriel.fernandez@st.com wrote: > > From: Gabriel Fernandez > > > > This patch exposes clk_gate_ops::is_enabled as functions > > that can be directly called and assigned in places like this so > > we don't need wrapper functions that do nothing besides forward > > the call. > > > > Signed-off-by: Gabriel Fernandez > > Sugested by Stephen Boyd > > --- > > drivers/clk/clk-gate.c | 2 +- > > include/linux/clk-provider.h | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/clk/clk-gate.c b/drivers/clk/clk-gate.c > > index 4e0c054a..e27e28f 100644 > > --- a/drivers/clk/clk-gate.c > > +++ b/drivers/clk/clk-gate.c > > @@ -86,7 +86,7 @@ static void clk_gate_disable(struct clk_hw *hw) > > clk_gate_endisable(hw, 0); > > } > > > > -static int clk_gate_is_enabled(struct clk_hw *hw) > > +int clk_gate_is_enabled(struct clk_hw *hw) > > { > > u32 reg; > > struct clk_gate *gate = to_clk_gate(hw); > > Don't you need to add an EXPORT_SYMBOL_GPL(clk_gate_is_enabled) as well > in case this gets used by modules? It would be needed in the future if someone uses it from a module. The only user in this patch series looks to be builtin only. I can add it when applying the patch if there aren't other comments on the series. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project