Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753100AbdGNBab (ORCPT ); Thu, 13 Jul 2017 21:30:31 -0400 Received: from mga04.intel.com ([192.55.52.120]:25174 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640AbdGNBaa (ORCPT ); Thu, 13 Jul 2017 21:30:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,356,1496127600"; d="scan'208";a="878739511" From: "Zhang, Tina" To: Kirti Wankhede , Gerd Hoffmann , "Tian, Kevin" , "linux-kernel@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "alex.williamson@redhat.com" , "zhenyuw@linux.intel.com" , "chris@chris-wilson.co.uk" , "Lv, Zhiyuan" , "intel-gvt-dev@lists.freedesktop.org" , "Wang, Zhi A" Subject: RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation Thread-Topic: [PATCH v10] vfio: ABI for mdev display dma-buf operation Thread-Index: AQHS9d72/JOqiz5kqkOIoMWmOT5rIKJGTuYAgAdZDwCAADHdAIABpeDA///SwgCAAFUVgIAC7Dhg Date: Fri, 14 Jul 2017 01:30:25 +0000 Message-ID: <237F54289DF84E4997F34151298ABEBC7C57E3FF@SHSMSX101.ccr.corp.intel.com> References: <1499293795-6265-1-git-send-email-tina.zhang@intel.com> <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com> <1499753648.8257.3.camel@redhat.com> <20170711091236.run4zirxmr34kazb@phenom.ffwll.local> <237F54289DF84E4997F34151298ABEBC7C57BF86@SHSMSX101.ccr.corp.intel.com> <20170712074038.izr6ureby4vwtq27@phenom.ffwll.local> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6E1UZc7000984 Content-Length: 3938 Lines: 96 > -----Original Message----- > From: intel-gvt-dev [mailto:intel-gvt-dev-bounces@lists.freedesktop.org] On > Behalf Of Kirti Wankhede > Sent: Wednesday, July 12, 2017 8:45 PM > To: Zhang, Tina ; Gerd Hoffmann > ; Tian, Kevin ; linux- > kernel@vger.kernel.org; intel-gfx@lists.freedesktop.org; > alex.williamson@redhat.com; zhenyuw@linux.intel.com; chris@chris- > wilson.co.uk; Lv, Zhiyuan ; intel-gvt- > dev@lists.freedesktop.org; Wang, Zhi A > Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation > > > > On 7/12/2017 1:10 PM, Daniel Vetter wrote: > > On Wed, Jul 12, 2017 at 02:31:40AM +0000, Zhang, Tina wrote: > >> > >> > >>> -----Original Message----- > >>> From: intel-gvt-dev > >>> [mailto:intel-gvt-dev-bounces@lists.freedesktop.org] On Behalf Of > >>> Daniel Vetter > >>> Sent: Tuesday, July 11, 2017 5:13 PM > >>> To: Gerd Hoffmann > >>> Cc: Tian, Kevin ; > >>> linux-kernel@vger.kernel.org; intel- gfx@lists.freedesktop.org; > >>> alex.williamson@redhat.com; zhenyuw@linux.intel.com; > >>> chris@chris-wilson.co.uk; Kirti Wankhede ; Lv, > >>> Zhiyuan ; daniel@ffwll.ch; Zhang, Tina > >>> ; intel-gvt- dev@lists.freedesktop.org; Wang, > >>> Zhi A > >>> Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf > >>> operation > >>> > >>> On Tue, Jul 11, 2017 at 08:14:08AM +0200, Gerd Hoffmann wrote: > >>>> Hi, > >>>> > >>>>>> +struct vfio_device_query_gfx_plane { > >>>>>> + __u32 argsz; > >>>>>> + __u32 flags; > >>>>>> + struct vfio_device_gfx_plane_info plane_info; > >>>>>> + __u32 plane_type; > >>>>>> + __s32 fd; /* dma-buf fd */ > >>>>>> + __u32 plane_id; > >>>>>> +}; > >>>>>> + > >>>>> > >>>>> It would be better to have comment here about what are expected > >>>>> values for plane_type and plane_id. > >>>> > >>>> plane_type is DRM_PLANE_TYPE_*. > >>>> > >>>> yes, a comment saying so would be good, same for drm_format which > >>>> is DRM_FORMAT_*. While looking at these two: renaming plane_type > >>>> to drm_plane_type (for consistency) is probably a good idea too. > >>>> > >>>> plane_id needs a specification. > >>> > >>> Why do you need plane_type? With universal planes the plane_id along > >>> is sufficient to identify a plane on a given drm device instance. I'd just > remove it. > >>> -Daniel > >> The plane_type here, is to ask the mdev vendor driver to return the > information according to the value in field plane_type. So, it's a input field. > >> The values in plane_type field is the same of drm_plane_type. And yes, it's > better to use drm_plane_type instead of plane_id. > > > > I have no idea what you mean here, I guess that just shows that > > discussing an ioctl struct without solid definitions of what field > > does what and why is not all that useful. What exactly it plane_id for then? > > > > plane type could be DRM_PLANE_TYPE_PRIMARY or > DRM_PLANE_TYPE_CURSOR. > > In case when VFIO region is used to provide surface to QEMU, plane_id would > be region index, for example region 10 could be used for primary surface and > region 11 could be used for cursor surface. So in that case, mdev vendor driver > should return plane_type and its corresponding plane_id. Thanks, Kirti, do you mean there will be multiple DRM_PLANE_TYPE_PRIMARY and multiple DRM_PLANE_TYPE_CURSOR planes existing in the same time and region usage needs to use plane_id to distinguish among them? Is it for the multiple output or that's the typical way of region usage? Thanks. Tina > > Thanks, > Kirti > > > This just confused me more ... > > -Daniel > > > _______________________________________________ > intel-gvt-dev mailing list > intel-gvt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev