Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753299AbdGNJGL convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Fri, 14 Jul 2017 05:06:11 -0400
Received: from mga01.intel.com ([192.55.52.88]:50809 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751362AbdGNJGJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jul 2017 05:06:09 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,358,1496127600"; 
   d="scan'208";a="878841100"
From: Jani Nikula <jani.nikula@linux.intel.com>
To: =?utf-8?Q?St=C3=A9phane?= Marchesin 
        <stephane.marchesin@gmail.com>,
        Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
Cc: Grant Grundler <grundler@chromium.org>,
        intel-gfx <intel-gfx@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "dri-devel\@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Michael Davidson <md@google.com>, Matthias Kaehlcke <mka@chromium.org>,
        Daniel Vetter <daniel.vetter@intel.com>,
        =?utf-8?Q?St=C3=A9phane?= Marchesin <marcheu@chromium.org>
Subject: Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches
In-Reply-To: <CACP_E+K_23gwXbuqGynvbqg+V4L5QHDEu_QXSg40gnVf4wBFzQ@mail.gmail.com>
References: <20170420215605.176722-1-mka@chromium.org> <20170505172636.GA128305@google.com> <20170505174043.GK12629@intel.com> <CADMs+9aA_Q2x-HCHLeccicDiqVW+KDpyDVawUDEovdHAwv6hRg@mail.gmail.com> <20170713101351.GS12629@intel.com> <CADMs+9aVfOx3WegtxqmyHF3MxANNeC8Ot3dkNN8uQhYLi5Y_Fg@mail.gmail.com> <20170713174232.GK12629@intel.com> <CACP_E+K_23gwXbuqGynvbqg+V4L5QHDEu_QXSg40gnVf4wBFzQ@mail.gmail.com>
Date: Fri, 14 Jul 2017 12:11:07 +0300
Message-ID: <87eftjl6xg.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 869
Lines: 23

On Thu, 13 Jul 2017, Stéphane Marchesin <stephane.marchesin@gmail.com> wrote:
> So, if you think this is wrong, can you fix this warning in a way that
> you'd like?

As I replied previously [1], with more background, fixing the warnings
properly, in a way that actually improves the code instead of making it
worse, would mean a bunch of churn that's not just purely mechanical
conversion.

Unless you can point out a bug which is actually caused by mixing the
types (which is mostly intentional, see the background) I have a hard
time telling people this should be a priority. Definitely something we'd
like to do in the long run and pedantically correct (and I tend to
prefer code that way) but we certainly have more important things to do.

BR,
Jani.

[1] http://mid.mail-archive.com/87wp9rahjy.fsf@intel.com


-- 
Jani Nikula, Intel Open Source Technology Center