Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753697AbdGNJ6r (ORCPT <rfc822;w@1wt.eu>);
        Fri, 14 Jul 2017 05:58:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33532 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753272AbdGNJ6q (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jul 2017 05:58:46 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 13FA879713
Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 13FA879713
Message-ID: <1500026320.28252.5.camel@redhat.com>
Subject: Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations
From: Gerd Hoffmann <kraxel@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>,
        Alex Williamson <alex.williamson@redhat.com>
Cc: Xiaoguang Chen <xiaoguang.chen@intel.com>, chris@chris-wilson.co.uk,
        intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        zhenyuw@linux.intel.com, zhiyuan.lv@intel.com,
        intel-gvt-dev@lists.freedesktop.org, zhi.a.wang@intel.com,
        kevin.tian@intel.com
Date: Fri, 14 Jul 2017 11:58:40 +0200
In-Reply-To: <42b821d9-9467-1679-3351-4a234243f520@nvidia.com>
References: <1497513611-2814-1-git-send-email-xiaoguang.chen@intel.com>
         <1497513611-2814-6-git-send-email-xiaoguang.chen@intel.com>
         <f19da207-a7f5-d3d3-4577-b071e7d75cf7@nvidia.com>
         <1497542438.29252.1.camel@redhat.com> <20170615143833.7526351b@w520.home>
         <24c4880b-24f5-ea07-834c-c77d3e895c78@nvidia.com>
         <20170616103959.3b6f1681@t450s.home> <1497854053.4207.2.camel@redhat.com>
         <20170619085409.26f5c14c@w520.home> <1497947703.16795.4.camel@redhat.com>
         <791b0316-1c83-622c-9cef-d54dae1209f9@nvidia.com>
         <1498029758.5802.1.camel@redhat.com>
         <42b821d9-9467-1679-3351-4a234243f520@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 14 Jul 2017 09:58:45 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 981
Lines: 36

  Hi,

> > > Right we need to know this at device initialization time for both
> > > cases
> > > to initialize VGACommonState structure for that device
> > 
> > Why do you need a VGACommonState?
> > 
> 
> We need to create a GRAPHIC_CONSOLE for vGPU device and specify
> GraphicHwOps so that from its .gfx_update callback, surface can be
> queried and updated.

Yes, you need GraphicHwOps, but there is no need to have a
VGACommonState for that.

> > > and also need
> > > NONE to decide whether to init console vnc or not. We have a
> > > mechanism
> > > to disable console vnc path and we recommend to disable it for
> > > better
> > > performance.
> > 
> > Hmm, maybe we should have a ioctl to configure the refresh rate, or
> > a
> > ioctl to allow qemu ask for a refresh when needed?
> > 
> 
> What is default refresh rate of QEMU if vnc is connected?

/* in ms */
#define GUI_REFRESH_INTERVAL_DEFAULT    30
#define GUI_REFRESH_INTERVAL_IDLE     3000

cheers,
  Gerd